webkom / lego

Backend for abakus.no
https://lego.abakus.no
MIT License
53 stars 20 forks source link

Fix bad naming of MSTCNNS #3471

Closed ivarnakken closed 1 year ago

ivarnakken commented 1 year ago

I suppose it needs to be uppercase like the rest? Mock tests still pass, but there's no way for me to actually test this ..

Again, I have no idea if this actually fixes the bug 🙃 Anyone got any ideas?

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9eeb403) 88.15% compared to head (7193b3b) 88.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3471 +/- ## ======================================= Coverage 88.15% 88.15% ======================================= Files 663 663 Lines 20937 20937 ======================================= Hits 18458 18458 Misses 2479 2479 ``` | [Files Changed](https://app.codecov.io/gh/webkom/lego/pull/3471?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom) | Coverage Δ | | |---|---|---| | [.../apps/users/tests/test\_student\_confirmation\_api.py](https://app.codecov.io/gh/webkom/lego/pull/3471?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom#diff-bGVnby9hcHBzL3VzZXJzL3Rlc3RzL3Rlc3Rfc3R1ZGVudF9jb25maXJtYXRpb25fYXBpLnB5) | `100.00% <ø> (ø)` | | | [lego/apps/users/constants.py](https://app.codecov.io/gh/webkom/lego/pull/3471?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom#diff-bGVnby9hcHBzL3VzZXJzL2NvbnN0YW50cy5weQ==) | `100.00% <100.00%> (ø)` | | | [lego/apps/users/models.py](https://app.codecov.io/gh/webkom/lego/pull/3471?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom#diff-bGVnby9hcHBzL3VzZXJzL21vZGVscy5weQ==) | `95.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.