webkom / lego

Backend for abakus.no
https://lego.abakus.no
MIT License
53 stars 20 forks source link

Remove report from search serializer #3486

Closed jonasdeluna closed 10 months ago

jonasdeluna commented 1 year ago

In the future we may want to allow searching for meeting reports you are a part of but this is a quick fix for the security issue.

Resolves: ABA-563

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (bb86cfb) 88.20% compared to head (bf23c06) 88.20%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3486 +/- ## ======================================= Coverage 88.20% 88.20% ======================================= Files 665 665 Lines 21060 21060 ======================================= Hits 18575 18575 Misses 2485 2485 ``` | [Files Changed](https://app.codecov.io/gh/webkom/lego/pull/3486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom) | Coverage Δ | | |---|---|---| | [lego/apps/meetings/serializers.py](https://app.codecov.io/gh/webkom/lego/pull/3486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom#diff-bGVnby9hcHBzL21lZXRpbmdzL3NlcmlhbGl6ZXJzLnB5) | `95.31% <ø> (ø)` | | | [lego/apps/meetings/search\_indexes.py](https://app.codecov.io/gh/webkom/lego/pull/3486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom#diff-bGVnby9hcHBzL21lZXRpbmdzL3NlYXJjaF9pbmRleGVzLnB5) | `83.33% <100.00%> (-5.56%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/webkom/lego/pull/3486/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

linear[bot] commented 1 year ago

ABA-563 Remove searching through meeting reports

norbye commented 11 months ago

Whops just noticed that this was set to canceled in linear - so maybe not heheh - just close the PR if it's not happening

danielyanghansen commented 10 months ago

As per ABA-563 and what we discuesed on our meeting like a month ago, this can be closed