search

webkom / lego

Backend for abakus.no
https://lego.abakus.no
MIT License
53 stars 20 forks source link

Implement lending system #3501

Open Arashfa0301 opened 11 months ago

Arashfa0301 commented 11 months ago

Resolves ABA-613

linear[bot] commented 10 months ago
ABA-613 Lending system

Backup has requested a lending system, as Abakus has a lot of objects that could be lent out to Ababeads if we just had a good system for it. Arrkom also wants this system to make it easier to administrate Soundboks and grill lending.

jonasdeluna commented 4 months ago

@eikhr I'll look closer at the comments after the 2 upcoming exams 👍👍

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 83.94794% with 148 lines in your changes are missing coverage. Please review.

Project coverage is 88.73%. Comparing base (6abb9ef) to head (cd58144). Report is 97 commits behind head on master.

Files Patch % Lines
lego/apps/lending/permissions.py 32.75% 39 Missing :warning:
lego/apps/lending/serializers.py 57.69% 22 Missing :warning:
lego/apps/forums/views.py 68.75% 20 Missing :warning:
lego/apps/lending/managers.py 0.00% 18 Missing :warning:
lego/apps/lending/views.py 65.21% 16 Missing :warning:
lego/apps/forums/permissions.py 73.07% 14 Missing :warning:
lego/apps/lending/notifications.py 0.00% 14 Missing :warning:
lego/apps/lending/models.py 95.00% 2 Missing :warning:
lego/apps/lending/validators.py 50.00% 2 Missing :warning:
lego/apps/joblistings/views.py 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3501 +/- ## ========================================== + Coverage 88.20% 88.73% +0.53% ========================================== Files 666 696 +30 Lines 21069 21726 +657 ========================================== + Hits 18584 19279 +695 + Misses 2485 2447 -38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jonasdeluna commented 3 months ago

@eikhr I've fixed your comments, notifications still don't work so they are removed for now. Will squash when merged.

jonasdeluna commented 3 months ago

I think something weird has happened during a rebase maybe? A lot of unrelated changes in the diff

Hmm actually I merged instead of rebasing, how can I resolve it now?

eikhr commented 3 months ago

I think something weird has happened during a rebase maybe? A lot of unrelated changes in the diff

Hmm actually I merged instead of rebasing, how can I resolve it now?

I don't know, I haven't seen this before. Maybe a rebase will help?