search

webkom / lego

Backend for abakus.no
https://lego.abakus.no
MIT License
53 stars 20 forks source link

Add revue to the permitted groups for the contact form #3511

Closed falbru closed 10 months ago

falbru commented 10 months ago

Initially, I wanted to add support for only contacting the revue board. However, the only way to achieve that would be to hardcode in the group id (or handle RevyStyret as a special group like we do Hovedstyret). I decided to just add support for all revue groups, because that was a lot easier.

Related to this PR.

falbru commented 10 months ago

LGTM, is there a frontend change adding the revue to the group picker or is that automatic?

Yup. This one.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6e6a8dc) 88.21% compared to head (c3d75cc) 88.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3511 +/- ## ======================================= Coverage 88.21% 88.21% ======================================= Files 666 666 Lines 21083 21084 +1 ======================================= + Hits 18598 18599 +1 Misses 2485 2485 ``` | [Files](https://app.codecov.io/gh/webkom/lego/pull/3511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom) | Coverage Δ | | |---|---|---| | [lego/apps/contact/serializers.py](https://app.codecov.io/gh/webkom/lego/pull/3511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=webkom#diff-bGVnby9hcHBzL2NvbnRhY3Qvc2VyaWFsaXplcnMucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.