search

webkom / lego

Backend for abakus.no
https://lego.abakus.no
MIT License
52 stars 20 forks source link

Remove user field from survey submission read serializer #3529

Open eikhr opened 8 months ago

eikhr commented 8 months ago

The surveys are supposedly anonymous, they are not when the user field is sent with the submission

TODO: [ ] Test that nothing breaks in lego-webapp

Resolves ABA-273

linear[bot] commented 8 months ago
ABA-273 Anonymize survey submissions

We claim that survey submissions are anonymous. They are not. We save the user corresponding to each submission, and even send the user and responses together in the "surveys/id/submissions" API-route.

eikhr commented 8 months ago

Turns out this breaks the survey submission page. It uses the user-field to find your own submission

jonasdeluna commented 5 months ago

Turns out this breaks the survey submission page. It uses the user-field to find your own submission

How about leaving it as null unless it's your submission, doing the finding in the backend instead?

ivarnakken commented 5 months ago

I agree with @jonasdeluna

It would be nice to separate this so that we can finally make /surveys a non-admin page. This has been requested by many people