webkom / lego

Backend for abakus.no
https://lego.abakus.no
MIT License
52 stars 20 forks source link

Introduce "too late" as an event presence status #3564

Closed ivarnakken closed 3 months ago

ivarnakken commented 4 months ago

Similar to the "not present" status, the user will automatically receive a penalty. I figured all previous penalties of type "presence" can be removed since they should not stack.

Also, this resolves a bug, as it is currently not possible to auto delete previous penalties related to the event due to the .delete() not being at the end the atomic block. Not sure why it had to be atomic in the first place.

linear[bot] commented 4 months ago

ABA-868 Give "too late" penalty on event attendees page

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.27%. Comparing base (c48fb05) to head (d7117b0). Report is 7 commits behind head on master.

:exclamation: Current head d7117b0 differs from pull request most recent head c9acb5f. Consider uploading reports for the commit c9acb5f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3564 +/- ## ========================================== + Coverage 88.24% 88.27% +0.03% ========================================== Files 677 679 +2 Lines 21385 21441 +56 ========================================== + Hits 18871 18927 +56 Misses 2514 2514 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.