Closed norbye closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.12%. Comparing base (
99fb7e5
) to head (1e5b944
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I agree this is an ok way to do it. But maybe add a test?
Absolutely(:
This pull request was deployed and Sentry observed the following issues:
/authorization/token-auth/
View IssueDid you find this useful? React with a 👍 or 👎
Not the cleanest code out there but for something that has to piggybank on the token generation to be able to generate the hash properly it felt like one of the most reliable ways of doing it as all the important logic is still performed by the rest_framework_jwt.
Open to other suggestions if anyone has any
Will need to be tested in staging to feel better about it, but works just fine for me locally.
The idea is to leave this in prod for a while to generate some hashes, and when the number of missing hashes is low enough we revert the PR.
Resolves ABA-920