search

webksde / ddev-vscode-devcontainer-drupal-template

Drupal DDEV based development container with attached Visual Studio Code
22 stars 3 forks source link

Fix https://github.com/webksde/ddev-vscode-devcontainer-drupal-templa… #141

Closed JPustkuchen closed 9 months ago

JPustkuchen commented 9 months ago

Fix https://github.com/webksde/ddev-vscode-devcontainer-drupal-template/issues/140

joshsedl commented 9 months ago

Furthermore, the "phpunit-coverage" script should be rewritten.

JPustkuchen commented 9 months ago

@joshsedl in my tests the version constraints were not needed anymore. You're right we should be careful with this, but if we can't find a reason anymore, let's remove it.

JPustkuchen commented 9 months ago

Of course we can split that removal! (But I think we should do / try both)

joshsedl commented 9 months ago

This needs further adjustments, the code coverage command is not properly working. We might also fix the "Xdebug: [Step Debug] Could not connect to debugging client. Tried: host.docker.internal:9003 (fallback through xdebug.client_host/xdebug.client_port)." problem here, while we are at it.

joshsedl commented 9 months ago

Alright, all done now everything works great again! The "Could not connect to debugging client" warning couldn't get resolved. But it was there before, so very unrelated. It also doesn't break anything (just looks like it). I'll create a follow-up issue for that. RTBC!

joshsedl commented 9 months ago

Created the seperate issue here: https://github.com/webksde/ddev-vscode-devcontainer-drupal-template/issues/143