search

webksde / ddev-vscode-devcontainer-drupal-template

Drupal DDEV based development container with attached Visual Studio Code
22 stars 3 forks source link

Add "ddev drupal" command #151

Closed JPustkuchen closed 6 months ago

JPustkuchen commented 7 months ago

I just needed to run ddev drupal generate:ajax:command and saw ddev drupal is not available.

We should add that shortcut. It simply calls the ./drupal or ./drupal.sh at web/core/scripts/

JPustkuchen commented 7 months ago

drupal.sh is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. There is no replacement. See https://www.drupal.org/node/3241346

JPustkuchen commented 7 months ago

So won't make sense to add this. I'll leave this open for @joshsedl to look into the core/scripts directory for possible other commands we might want to provide eventually (as separate tasks then).

JPustkuchen commented 7 months ago

For my case I opened https://github.com/drush-ops/drush/issues/5834

JPustkuchen commented 7 months ago

Just found out that ./drupal is something different than ./drupal.sh - so it might still make sense to add that command then!

joshsedl commented 6 months ago

Yes, I will add a shortcut! FYI, I don't think any of the other scripts make sense here! But I'll definitly add a shortcut for drupal

joshsedl commented 6 months ago

Are you really sure you meant ddev drupal generate:ajax:command this sounds like a ddev drush command rather than ddev drupal? Also googling it, I couldn't find this command.

This is the output, when running the drupal php script: image

Doesn't look much of use.

JPustkuchen commented 6 months ago

@joshsedl see https://github.com/webksde/ddev-vscode-devcontainer-drupal-template/issues/151#issuecomment-1847509437 and https://github.com/webksde/ddev-vscode-devcontainer-drupal-template/issues/151#issuecomment-1847519615

But there's a theoretical use-case: Generating a new theme from the kit: https://www.drupal.org/docs/develop/theming-drupal/creating-sub-themes

So if it's just a shortcut, add ddev drupal to run the command you screenshoted. If not, just close this. And please finally take a look if there are any other relevant .sh files in that folder that we should add as shortcut. Maybe not.

joshsedl commented 6 months ago

Please see https://github.com/webksde/ddev-vscode-devcontainer-drupal-template/issues/151#issuecomment-1847519615 🌝 drupal.sh != drupal

And we can simply generate a theme using drush gen, seems like the script isn't of much need. Gonna close this. And yea, no other relevant .sh files unfortunately.