search

webksde / ddev-vscode-devcontainer-drupal-template

Drupal DDEV based development container with attached Visual Studio Code
23 stars 3 forks source link

Upgrade to PHP 8 #56

Closed joshsedl closed 2 years ago

JPustkuchen commented 2 years ago

Yep definitely makes sense for Drupal 9 by default.

joshsedl commented 2 years ago

Ok, currently not possible, we will have to wait for rfay to fix this: https://github.com/drud/ddev/issues/3278

joshsedl commented 2 years ago

Apparently this is fixed now, I will switch to PHP 8.1 experimentally and reopen this issue if it does not work.

joshsedl commented 2 years ago

Fixed in https://github.com/webksde/ddev-vscode-devcontainer-drupal9-template/commit/ae83ff4c0e93dbe65392163564f040e392524c5b

joshsedl commented 2 years ago

Ok, seems to work great!

The main problem with php 8, that phpunit would not work anymore, is not present!