search

webksde / ddev-vscode-devcontainer-drupal-template

Drupal DDEV based development container with attached Visual Studio Code
23 stars 3 forks source link

drowl-init-from-existing: Should we (also) require the composer.lock file? #64

Open JPustkuchen opened 2 years ago

JPustkuchen commented 2 years ago

@joshsedl please see if we should also require the composer.lock file and learn / tell us what's the best pracitice. I guess it's to 100% ensure the actual dependency versions are used... saw it in some composer projects where composer.json AND composer.lock was present...

I guess it's optional for us... perhaps add not to the confirm ...

(and optionally composer.lock)

if it makes sense?

JPustkuchen commented 1 year ago

Yes I still think it should be optional! But typically the lock file is what you would use to have a 1:1 copy of existing projects!