webksde / ddev-vscode-devcontainer-drupal-template

Drupal DDEV based development container with attached Visual Studio Code
23 stars 3 forks source link

Do not set rebuild_access=true in local.settings.php #79

Closed JPustkuchen closed 2 years ago

JPustkuchen commented 2 years ago

admin/reports/status says:

Zugriff neu aufbauen Aktiviert Die Einstellung rebuild_access, in der Datei settings.php. ist aktiviert. Es wird empfohlen, diese Einstellung zu deaktivieren, wenn Sie keinen Neuaufbau der Drupal-Caches durchführen.

And as we did never require using this so far in our development, I guess it should not need to set to true by default. Or was there any specific reason / problem?

JPustkuchen commented 2 years ago

Background: That setting controls if access records are rebuilt on each request. As we typically don't change access records frequently nor use the environment to write such modules, it's an edge case which is better not to implement by default.

If someone needs it for such a case (which has never been the case in company history), he / she should know about that setting or rebuild permissions manually.

JPustkuchen commented 2 years ago

Created a pull request for this: https://github.com/webksde/ddev-vscode-devcontainer-drupal9-template/pull/84

joshsedl commented 2 years ago

Sounds good!

joshsedl commented 2 years ago

Merged.