webksde / ddev-vscode-devcontainer-drupal-template

Drupal DDEV based development container with attached Visual Studio Code
23 stars 3 forks source link

ddev drowl-init throws error [Seld\JsonLint\ParsingException] "" does not contain valid JSON #92

Closed JPustkuchen closed 2 years ago

JPustkuchen commented 2 years ago

grafik

[Seld\JsonLint\ParsingException]
  "" does not contain valid JSON
  Parse error on line 1:
  '{"INSERT WHAT IT DO
  ^
  Invalid string, it appears you used single quotes instead of double quotes

On first initialization in a fresh project. Using ddev 1.19.1

JPustkuchen commented 2 years ago

Looks like this line fails:

https://github.com/webksde/ddev-vscode-devcontainer-drupal9-template/blob/d5e44e8a6e8ffde4d4226b635d4d9b5ae3391c1a/.ddev/commands/host/drowl-init.sh#L70

JPustkuchen commented 2 years ago

I'll try to fix it.

JPustkuchen commented 2 years ago

Fixed in https://github.com/webksde/ddev-vscode-devcontainer-drupal9-template/pull/93

joshsedl commented 2 years ago

Thanks @JPustkuchen! :)

joshsedl commented 2 years ago

Note, that this change will make ddev >=1.19.1 required!

JPustkuchen commented 2 years ago

Thanks @joshsedl - but I think that's OK... please notify the team to upgrade. I used brew for that.