search

webmachine / webmachine-ruby

Webmachine, the HTTP toolkit (in Ruby)
http://rdoc.info/github/seancribbs/webmachine-ruby/master/frames
Other
852 stars 54 forks source link

fix: implement rfc3986 Percent-Encoding decoder #257

Closed uglyog closed 3 years ago

uglyog commented 3 years ago

Implemented a simple rfc3986 Percent-Encoding decoder.

The use of URI.decode in the router prints the following warnings:

.../webmachine-ruby/lib/webmachine/dispatcher/route.rb:137: warning: URI.unescape is obsolete
.../webmachine-ruby/lib/webmachine/dispatcher/route.rb:137: warning: URI.unescape is obsolete

URI.unescape is deprecated with no replacement.

This method is obsolete and should not be used. Instead, use CGI.unescape, URI.decode_www_form or URI.decode_www_form_component depending on your specific use case.

bethesque commented 3 years ago

Ron you champion. I just tried to get master build passing but the offspring are getting demanding, so I'll have to leave it for someone who knows what they're doing.

seancribbs commented 3 years ago

@bethesque The Travis builds haven't been working correctly for a long time. I don't really have time to set up a different build system, but it'd be great to move off Travis.

bethesque commented 3 years ago

I'm getting the same failures as Travis locally - NameError: uninitialized constant Celluloid::FSM. I thought it might be something to do with the refactor of the celluloid gem, but didn't get a chance to look too deeply.

bethesque commented 3 years ago

I'm going to put this out in a release sometime soon unless anyone has any objections. It's been a while, but I'm pretty sure I have the permissions.

bethesque commented 3 years ago

Meant to release this yesterday, but ran out of time getting the builds green again. Will do it on my next OSS day in a fortnight.

bethesque commented 3 years ago

Finally released this!