webmachinelearning / webnn

🧠 Web Neural Network API
https://www.w3.org/TR/webnn/
Other
398 stars 48 forks source link

Drop the support of synchronous execution #548

Closed huningxin closed 9 months ago

huningxin commented 10 months ago

Remove the definition and algorithm steps for

This PR also removes the synchronous execution description from Programming Model section.

The previous algorithm steps of MLGraphBuilder.build() depends on MLGraphBuilder.buildSync(). The algorithm steps of MLGraphBuilder.buildSync() have issue tracked by #457. That is left to a separate PR. This PR just merges the algorithm steps of MLGraphBuilder.buildSync() into MLGraphBuilder.build() with some modifications:

Fix #531

@wchao1115 @anssiko @inexorabletash , PTAL. Thanks!


Preview | Diff

inexorabletash commented 10 months ago

The bots seem to be having issues, but I've locally verified that there are no Bikeshed warnings or errors.

zolkis commented 10 months ago

PR preview failed, just wanted to call attention to common usage of "execute graph" and other algorithms from the "Synchronous execution" section also in asynchronous execution. These should be moved or merged into the async execution steps. It's hard to see from the diff if that was the case.

anssiko commented 9 months ago

By merging, we're checking some boxes: