Update the programming model section

webmachinelearning / webnn

🧠 Web Neural Network API

https://www.w3.org/TR/webnn/

Other

398 stars 48 forks source link

Update the programming model section #549

Closed anssiko closed 8 months ago

anssiko commented 10 months ago

Review and update the programming model section to ensure it still reads well and is up to date with the rest of the specification. This section can be used as a place to define concepts that apply globally.

anssiko commented 10 months ago

PR #540 defines global concepts "platform operator" and "platform operand".

inexorabletash commented 10 months ago

Some terms that would be good to define:

"tensor" and "shape"
"connect", "input" and "output" (referenced in operand creation steps)
"register" (e.g. "register ... as a graph output", "register it as an activation to ...", "register ... as a tensor constant", etc.)

inexorabletash commented 9 months ago

If you're following this issue, please review: https://github.com/webmachinelearning/webnn/issues/572#issuecomment-1962198054

anssiko commented 9 months ago

Programming Model changes in https://github.com/webmachinelearning/webnn/issues/572#issuecomment-1962198054 LGTM.

Edit: Should we also say the nodes of the graph are connected by edges, represented by MLOperands? This is complementary to "MLOperands representing the data flow" but using graph theory language.

inexorabletash commented 9 months ago

Edit: Should we also say the nodes of the graph are connected by edges, represented by MLOperands? This is complementary to "MLOperands representing the data flow" but using graph theory language.

Updated to read:

An operator's input is one or more MLOperands representing the data flow for the computation, and are the edges of the graph. Operands include input values...

inexorabletash commented 8 months ago

@anssiko - now that #591 is merged, do you think we can close this out and have more specific issues if needed?

anssiko commented 8 months ago

Yes we can. Much thanks for doing a pass also on this part of the spec that I believe will be read by many web developers and people interested in the lay of the land.