Content: The input of triangular should be at least 2D tensor

webmachinelearning / webnn

🧠 Web Neural Network API

https://www.w3.org/TR/webnn/

Other

398 stars 48 forks source link

Content: The input of triangular should be at least 2D tensor #550

Closed inexorabletash closed 9 months ago

inexorabletash commented 10 months ago

Fixes #494 which has the text and example. I added the validation step which matches the webnn-baseline impl referenced therein.

"2-D" seems to be used more commonly than "2D" in the spec
"batches" doesn't seem to be rigorously defined - room for future improvement here and in matmul?

Preview | Diff

inexorabletash commented 10 months ago

@fdwr and @BruceDai can you do an initial review?

fdwr commented 10 months ago

Oh this is great - had it on my queue for a while but haven't popped it 😢. Thanks Joshua. 👏

fdwr commented 9 months ago

fdwr and BruceDai can you do an initial review?

Bruce is on vacation for Chinese New Year two weeks, but I think he'd be content to merge it as he originally opened the issue on behalf of my comment anyway while reviewing his tests, and Ningxin reviewed it already.

anssiko commented 9 months ago

@fdwr please feel free to merge and we’ll check the GH permission knobs are properly set for you at the same time.