webmachinelearning / webnn

🧠 Web Neural Network API
https://www.w3.org/TR/webnn/
Other
397 stars 48 forks source link

Styles: simplify algorithm markup, improve step & dfn visibility #594

Closed inexorabletash closed 8 months ago

inexorabletash commented 9 months ago

No content changes.


Preview | Diff

inexorabletash commented 9 months ago

@zolkis - can you take a look? There may be history around these styles/markup that I'm missing that merits keeping them.

inexorabletash commented 9 months ago

While I'm here (but this question shouldn't hold up this PR)...

@zolkis the CSS for internal slots sets it up for a watermark like "Algorithm" has but there's no .internal-slots::after { content: ... } rule that actually provides the watermark text. Do you know if that was intended in 1c894021d30ef70c9ecdfbe79b4961c483fc7581 but lost somehow?

zolkis commented 9 months ago

the CSS for internal slots sets it up for a watermark like "Algorithm" has but there's no .internal-slots::after { content: ... } rule that actually provides the watermark text. Do you know if that was intended in 1c89402 but lost somehow?

Right, it's missing - the intent was to make internal slots stand out in a similar way, though now we should check if we still want that. BTW I will be on holiday for a week, with sparse internet, so apologies in advance if replies will come late.

inexorabletash commented 9 months ago

the intent was to make internal slots stand out in a similar way, though now we should check if we still want that

If the editors want to weigh in:

image

vs:

image

Literally a one line change, so easy to slip in:

@@ -116,6 +116,7 @@
 .internal-slots::after {
+    content: "Internal Slots";
inexorabletash commented 8 months ago

@huningxin - please merge when you're ready.

huningxin commented 8 months ago

@inexorabletash Please help resolve the merge conflicts and I'll merge. Thanks!

inexorabletash commented 8 months ago

@huningxin - resolved!