Content: Clarify the expected behavior for axes being empty

webmachinelearning / webnn

🧠 Web Neural Network API

https://www.w3.org/TR/webnn/

Other

397 stars 48 forks source link

Content: Clarify the expected behavior for axes being empty #599

Closed inexorabletash closed 8 months ago

inexorabletash commented 9 months ago

The shape calculation for argMin/argMax and reduction ops is now fully specified, but the implied behavior of {axes:[]} for these ops and layerNormalization was not particularly clear.

Add a little text to make it clearer.

Fixes #493

Preview | Diff

inexorabletash commented 9 months ago

@BruceDai can you take an initial look?

BruceDai commented 8 months ago

I apologize for my late response.

LGTM, thanks for these clarification texts.

inexorabletash commented 8 months ago

Thanks @BruceDai - and no worries. I'm generating a lot of review requests. @fdwr and @huningxin - please review/merge at your leisure!