Previously the spec had a "validate MLOperand" helper that (1) ensured the operand was from the passed MLGraphBuilder and (2) that the operand was internally consistent, and this was called during (3) build() and (4) only concat() among the vending methods.
(1) is needed but can be done when the MLOperand is created, giving better feedback, so (3) isn't needed.
(2) is not needed - MLOperands are immutable so they can't be created in a bad state.
(4) should be expanded to all MLOperand creations that take input MLOperands.
This renames the helper, ensures it is called by every MLOperand vending method that takes MLOperand inputs, and drops it from build(). Similar validation is added for MLActivation inputs.
Previously the spec had a "validate
MLOperand" helper that (1) ensured the operand was from the passedMLGraphBuilderand (2) that the operand was internally consistent, and this was called during (3)build()and (4) onlyconcat()among the vending methods.(1) is needed but can be done when the
MLOperandis created, giving better feedback, so (3) isn't needed.(2) is not needed -
MLOperandsare immutable so they can't be created in a bad state.(4) should be expanded to all
MLOperandcreations that take inputMLOperands.This renames the helper, ensures it is called by every
MLOperandvending method that takesMLOperandinputs, and drops it frombuild(). Similar validation is added forMLActivationinputs.For #572
Preview | Diff