gru/lstm: Fix missing/incorrect variables and options use

webmachinelearning / webnn

🧠 Web Neural Network API

https://www.w3.org/TR/webnn/

Other

341 stars 42 forks source link

Closed inexorabletash closed 1 month ago

inexorabletash commented 1 month ago

In gru(), batchSize and numDirections were used without being defined. Define them.
In lstm(), numDirections was initialized to 2 if the direction was "backward", should be 1.
In gru() and gruCell(), options.activations was unconditionally added to the operator. Make this conditional.
In lstm() and lstmCell(), options.activations were not added to the operator. Add if given.

inexorabletash commented 1 month ago

Straightforward fixes noticed while working on other PRs. Please take a look?

inexorabletash commented 1 month ago

@huningxin - can you review and merge if it looks good? Thanks!