search

webmachinelearning / webnn

🧠 Web Neural Network API
https://www.w3.org/TR/webnn/
Other
397 stars 48 forks source link

Rename the logical operation "not" to "logicalNot" #692

Closed shiyi9801 closed 6 months ago

shiyi9801 commented 6 months ago

As per discussion in #496, use name "logicalNot" to reduce ambiguity.

Preview | Diff

w3cbot commented 6 months ago

anssiko marked as non substantive for IPR from ash-nazg.

anssiko commented 6 months ago

@shiyi9801 thanks for the contribution. I have cleared the CI check for you.

This automated CI check is in place to ensure contributions containing so-called substantive changes come from WG participants only. Since this change is a rename it is considered non-substantive from the IPR point of view. Frequent contributors who are planning to contribute substantive changes are expected to join the WG.

inexorabletash commented 6 months ago

LGTM as well.

anssiko commented 6 months ago

@fdwr @huningxin, we did not have time to discuss this in our meeting today. If you editors feel some individuals should be consulted prior to merge please tag them here. If this is considered straightforward change and you are confident you can manage the impact of this rename on the layers above, then you can merge. I trust in your judgment on this matter.

@shiyi9801 if you plan on making substantive contributions in this WG, my expectation is you will join the group. Alternatively you can let Intel's current participants submit the PRs with credits to you.

huningxin commented 6 months ago

@fdwr @huningxin, we did not have time to discuss this in our meeting today. If you editors feel some individuals should be consulted prior to merge please tag them here. If this is considered straightforward change and you are confident you can manage the impact of this rename on the layers above, then you can merge. I trust in your judgment on this matter.

I think this PR got 3 approvals and is good to merge.

@shiyi9801 if you plan on making substantive contributions in this WG, my expectation is you will join the group. Alternatively you can let Intel's current participants submit the PRs with credits to you.

Thanks for the guidance. I can coordinate with Shiyi for other potential PRs.