search

webmachinelearning / webnn

🧠 Web Neural Network API
https://www.w3.org/TR/webnn/
Other
397 stars 47 forks source link

Specify MLTensor #787

Open a-sully opened 1 week ago

a-sully commented 1 week ago

This PR specifies key methods related to MLTensor, while hand-waving over much of the juicy details, such as how to actually specify the MLContext's timeline (#529)

My hope is that this is a mostly-straightforward improvement which is "good enough" to allow us to remove MLContext.compute() as well as providing a more concrete starting point for more detailed discussions about e.g. specifying timelines in follow-up PRs

Preview | Diff

a-sully commented 1 week ago

There's one remaining trivial bikeshed error which I intend to fix tomorrow. Please don't let that stop you from reviewing this PR :)

Thanks!

Update: This error is now fixed 🟢

a-sully commented 1 week ago

Apologies for the accidental force-push 🤦

Thanks for the feedback @inexorabletash! I believe I've addressed all your comments

a-sully commented 4 days ago

Thanks for the review! Feel free to merge at your convenience 🙏

huningxin commented 3 days ago

@inexorabletash @reillyeon Any further comments? Also add @fdwr , PTAL.