webmastak / gnome-shell-extensions-mediaplayer

A mediaplayer indicator for GNOME Shell 3.18+.
https://extensions.gnome.org/extension/55/media-player-indicator/
GNU General Public License v2.0
376 stars 106 forks source link

Makefile:466: *** missing separator. Stop. #156

Closed crosswalk-zz closed 10 years ago

crosswalk-zz commented 10 years ago

After running the following command for the generation for configuration and Makefiles, I get an error described by the title of the issue. Are there any known fixes for this error?

crosswalk-zz commented 10 years ago

I should mention that this installation is being attempted on Debian Wheezy x86_64, GNOME Shell version 3.4.

eonpatapon commented 10 years ago

Please post the complete log.

crosswalk-zz commented 10 years ago

Here's the output for ./autogen.sh:

/usr/bin/gnome-autogen.sh checking for autoconf >= 2.53... testing autoconf2.50... not found. testing autoconf... found 2.69 checking for automake >= 1.9... testing automake-1.11... found 1.11.6 checking for intltool >= 0.30... testing intltoolize... found 0.50.2 Checking for required M4 macros... Checking for forbidden M4 macros... Processing ./configure.ac Running intltoolize... Running aclocal-1.11... Running autoconf... Running automake-1.11... Running ./configure ... checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... /bin/mkdir -p checking for gawk... no checking for mawk... mawk checking whether make sets $(MAKE)... yes checking how to create a ustar tar archive... gnutar checking whether make supports nested variables... yes checking whether NLS is requested... yes checking for style of include used by make... GNU checking for gcc... gcc checking whether the C compiler works... yes checking for C compiler default output file name... a.out checking for suffix of executables... checking whether we are cross compiling... no checking for suffix of object files... o checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for gcc option to accept ISO C89... none needed checking dependency style of gcc... none checking for intltool >= 0.26... 0.50.2 found checking for intltool-update... /usr/bin/intltool-update checking for intltool-merge... /usr/bin/intltool-merge checking for intltool-extract... /usr/bin/intltool-extract checking for xgettext... /usr/bin/xgettext checking for msgmerge... /usr/bin/msgmerge checking for msgfmt... /usr/bin/msgfmt checking for gmsgfmt... /usr/bin/msgfmt checking for perl... /usr/bin/perl checking for perl >= 5.8.1... 5.14.2 checking for XML::Parser... ok checking for pkg-config... /usr/bin/pkg-config checking pkg-config is at least version 0.22... yes ./configure: line 4270: GLIB_GSETTINGS: command not found configure: creating ./config.status config.status: creating Makefile config.status: creating po/Makefile.in config.status: creating src/Makefile config.status: executing depfiles commands config.status: executing po/stamp-it commands Now type `make' to compile gnome-shell-extensions-mediaplayer

And here's the output from make:

Making all in src make[1]: Entering directory /home/stephen/Documents/gnome-shell-extensions-mediaplayer/src' make[1]: Leaving directory/home/stephen/Documents/gnome-shell-extensions-mediaplayer/src' Makefile:466: * missing separator. Stop. make: * [all-recursive] Error 1

eonpatapon commented 10 years ago

Have you installed glib2 devel files (libglib2.0-dev on debian) ?

crosswalk-zz commented 10 years ago

I installed the glib2 development files and was able to build and install the extension, but the extension does not seem to be supported by the version of Gnome Shell I'm running which is 3.4.2. Is this a bug or is my current Gnome Shell version simply not supported?

eonpatapon commented 10 years ago

Use the gnome-shell-3.8 branch for 3.4.2

crosswalk-zz commented 10 years ago

I have run "sudo make uninstall" in the directory containing the master branch's code and then ran the installation for the 3.8 branch, but I am still not able to toggle the Media player indicator extension. The tool tip in the gnome-tweak-tool still reads "Extensions does not support shell version". Is there additional information I can give you to help fix this?

eonpatapon commented 10 years ago

Have you tried to install the extension from extensions.gnome.org ?

crosswalk-zz commented 10 years ago

That was the first location from which I tried to install the extension. The page is faded and there is a symbol marking my shell as outdated.

eonpatapon commented 10 years ago

Try to add "3.4.2" in the metadata.json.in versions list and run make install-zip again.

crosswalk-zz commented 10 years ago
{
"uuid": "@UUID@",
"name": "Media player indicator",
"description": "Control MPRIS2 capable media players: Rhythmbox, Banshee, Clementine and more. Check the home page for more details.",
"original-author": "eon@patapon.info",
"shell-version": [ "3.4.2", "3.10", "3.11", "3.12" ],
"url": "@URL@",
"locale": "@LOCALEDIR@"
}

I am still not able to enable the Media player indicator extension with the change to the metadata.json.in file that I have posted above.

eonpatapon commented 10 years ago

If you have "3.10", "3.11", "3.12" in the list it's the master branch. You need the gnome-shell-3.8 branch: https://github.com/eonpatapon/gnome-shell-extensions-mediaplayer/blob/gnome-shell-3.8/src/metadata.json.in

crosswalk-zz commented 10 years ago

So how do I select the 3.8 branch? I'm using the drop-down menu at the top of the screen and selecting the 3.8 branch and cloning the link on that page. Is the link on the page after selecting the 3.8 branch not supposed to be used to clone the 3.8 branch?

Also, after using the file you have linked I am still seeing no change in the gnome-tweak-tool or on extensions.gnome.org.

eonpatapon commented 10 years ago

Once you have cloned the repo, do:

git branch (tells you the branch you are on)
git checkout -b gnome-shell-3.8 origin/gnome-shell-3.8 (switch to the gnome-shell-3.8 branch)
modify the metadata.json.in
./autogen.sh
make install-zip
restart the shell (alt+f2 r)
activate de extension with gnome tweak tool
crosswalk-zz commented 10 years ago

After switching to the gnome-shell-3.8 branch I was able to build and get the extension running properly. Thank you for your help.

eonpatapon commented 10 years ago

You are welcome