search

webmastak / gnome-shell-extensions-mediaplayer

A mediaplayer indicator for GNOME Shell 3.18+.
https://extensions.gnome.org/extension/55/media-player-indicator/
GNU General Public License v2.0
376 stars 106 forks source link

Song information isn’t updated #435

Closed fbruetting closed 6 years ago

fbruetting commented 6 years ago

I just listened to an album via Lollypop, then paused it (via middle-click on the status icon) and started playback of a file via Gnome-MPV (but I don’t know if I first paused the first and then started the second, or vice versa). Now what I see is the MPV icon, then a start/stop indicator (which works for Gnome-MPV) – but then the name of the current (paused) song of Lollypop.

Seems you have forgotten to reset all MPRIS object attributes (or whatever this is called) when players are changed…? (Maybe Gnome-MPV (Flatpak) or the file don’t emit tag information, which could also lead to skipping updating the song name?)

JasonLG1979 commented 6 years ago

Those just so happen to be my choices for music and video payers also. Although I generally don't install the Flatpak versions. I'll see what the deal is and report back here in a bit.

fbruetting commented 6 years ago

Now I had the Gnome-MPV window still open, but deleted the file I played with it and pressed “play” on my keyboard. This led to the status icon being changed back to the Lollypop song – but the playback signal was sent to Gnome-MPV (of which I of course got an error displayed, due to the now missing file) and Lollypop never received the “play” signal.

I expect here no change of the status icon, because Gnome-MPV still was the active player.

JasonLG1979 commented 6 years ago

@fbruetting does that work for you?

fbruetting commented 6 years ago

Have you seen my second writing? ;)

JasonLG1979 commented 6 years ago

Yep that would be a different bug.

fbruetting commented 6 years ago

Should I file a new one?

JasonLG1979 commented 6 years ago

Please.

JasonLG1979 commented 6 years ago

This bug from what I can tell is that the panel text was not being updated correctly. My latest commit should fix that.

fbruetting commented 6 years ago

Oh, I deleted my file, I played with Gnome-MPV permanently… :/

JasonLG1979 commented 6 years ago

Well that sucks, I'm sorry.

fbruetting commented 6 years ago

I’ll search my server… not important for me at all, but for reproducing…

JasonLG1979 commented 6 years ago

Backups are your friend. I personally have triple local redundancy plus offsite.

fbruetting commented 6 years ago

Yeah, this was my backup – because I don’t need it anymore. :P So I can’t reproduce it, but I’ll write you, if I see this again!

JasonLG1979 commented 6 years ago

I mostly use my backups for media. I have like 600 movies ripped(that I own so it's legal as much as the MPA would have you not believe.) That I use with a Plex server and a couple Rokus to make sure my kids don't scratch up the discs. I don't want to rip them all over again. I had a drive fail at the 200 movie mark and I said never again. Ripping 600 movies would take weeks...

fbruetting commented 6 years ago

I got a FreeNAS with Raid-Z1 for media & backups on mirrored disks, but use Kodi on a dedicated HTPC. FreeBSD with ZFS is the best you can get for servers or NAS systems! :)

JasonLG1979 commented 6 years ago

FreeBSD with ZFS is the best you can get for servers or NAS systems! :)

I'm not going to argue with that. I don't have a NAS, just a few TB's of USB hard drives and the Plex server. The Plex server just does Plex, that's it. I use sshfs to transfer files to it manually.