search

webmastak / gnome-shell-extensions-mediaplayer

A mediaplayer indicator for GNOME Shell 3.18+.
https://extensions.gnome.org/extension/55/media-player-indicator/
GNU General Public License v2.0
376 stars 106 forks source link

Extra space appears after status text #462

Closed arngo closed 5 years ago

arngo commented 5 years ago

When the indicator is reloaded (i.e. when changing the position (left/center/right/system menu), locking/unlocking the screen, reloading the extension), an extra margin appears to the right of the status text if it is set. This is much more noticeable on the Adapta shell theme than it is on the default, where only a few pixels might appear.

This only seems to occur when the status text does not reach the set maximum width, i.e "Indicator Status Text Width", and when there is only one player running. The problem goes away when the next song starts playing or when the status text format is changed.

This issue started with this commit: https://github.com/JasonLG1979/gnome-shell-extensions-mediaplayer/commit/71e44f9b7f49acc4c9908b11ea00f69b8cc922c2

Distro: Arch Linux GNOME Shell version 3.30.2 Players tested: Quodlibet and Lollypop Extension version: Current git master

JasonLG1979 commented 5 years ago

I just tested on the Adapta theme and without the text being truncated I get 15px of padding no matter what.

screenshot from 2018-11-21 19-08-23 screenshot from 2018-11-21 19-07-42 screenshot from 2018-11-21 19-07-31

JasonLG1979 commented 5 years ago

What is the content exactly of your Indicator Status Text setting text box?

arngo commented 5 years ago

I have it as {trackArtist • }{trackTitle}

JasonLG1979 commented 5 years ago

That's correct formatting, btw like the dot. I was wondering if you had any whitespace between the curlies and you don't so that's good. I'll play with some more after Thanksgiving and see if I can reproduce the issue.

arngo commented 5 years ago

Alright, thanks. Have a good holiday!

JasonLG1979 commented 5 years ago

https://github.com/JasonLG1979/gnome-shell-extensions-mediaplayer/blob/master/README.md