search

webmaster94 / Waterdeep-City-of-Splendors

A full Waterdeep map with all locations as presented by https://www.aidedd.org/
GNU General Public License v3.0
12 stars 5 forks source link

V9 update needed for this line #1

Closed datanerd3000 closed 2 years ago

datanerd3000 commented 2 years ago

https://github.com/webmaster94/Waterdeep-City-of-Splendors/blob/acaf97f2963ab0fa467acdf9fe1af72d73cd1ca4/scripts/waterdeep.js#L26

With foundry v9, they've updated the underlying process. I've found this works with v9 canvas.scene.createEmbeddedDocuments("Note", noteDataResolved); instead of canvas.notes.createMany(noteDataResolved);

webmaster94 commented 2 years ago

Thank you for advising me on the syntax change in V9. I had not tried the script in v9 as I was still on v8 when I used it. I will evaluate the change you have suggested and let you know.

webmaster94 commented 2 years ago

The module itself should work fine in v9 however. The script is only if you want to avoid using the content presented in the module.

Gacky2k commented 2 years ago

Works great! Thank you for sharing!

webmaster94 commented 2 years ago

@datanerd3000 sorry about the delay in the fix. I have been very busy and have not had time to check that the fix suggested works. I have now verified that and updated the script appropriately, thank you for your suggestion.