Closed yanick closed 5 years ago
Definitely!
One minor thing that has to do with my unjustifiable OCD; please use hard tabs of 2 spaces in the following:
Thanks @yanick!
please use hard tabs of 2 spaces in the following
Barbarian. ;-) But your house, your rules. Spaces are tabified.
And I didn't know if you wanted to make sorting by reverse date
the default. On one hand, it makes sense, on the other, it's a change in default behavior. So I kept the PR minimal, leaving you with the liberty to do what you'd prefer.
Enjoy! :-)
Barbarian. ;-) But your house, your rules. Spaces are tabified
Tell me about it! I have to live with that!
I like it minimal just the way you did it, this way it defaults to however the pages are passed in extendPageData
, which currently, if I'm not mistaken, default to descending by date.
Thanks again @yanick!
I like it minimal just the way you did it, this way it defaults to however the pages are passed in extendPageData, which currently, if I'm not mistaken, default to descending by date.
Either desc by date or random. I just saw that it didn't do exactly what I did, so I dove in. ^.^
Thanks for the quick response, and thanks for an awesome plugin. This makes feed generation as painless as it can be, which is :100:.
Thanks you @yanick! You made my day!
Add a
sort
option to sort the entriesDescription
Right now there is no sorting done on the feed entries. For feeds that have more entries than the
count
option allows, one might want to get the latest entries, or the most popular, etc. Hence the need to be able to sort the entries.