webmaxru / node-red-contrib-web-push

A Node-RED node for sending Web Push notifications using VAPID
https://www.npmjs.com/package/node-red-contrib-web-push
6 stars 7 forks source link

Update web push dependency 3.3.2 to 3.4.4 #10

Closed bartbutenaers closed 3 years ago

bartbutenaers commented 3 years ago

Hi @webmaxru,

This pull request updates the web-push dependency from version 3.3.2 to version 3.4.4, to solve this issue. Which is important because otherwise we create conflicts for the migrated http-request node starting from Node-RED 2.0?

Via the npm list command, you can now see that we have the required agent-base version:

image

There have been a lot of intermediate releases between web-push version 3.3.2 and 3.4.4, but almost all commits were related to updating versions of dependencies. Only following commits have added new features:

1) commit allows a http agent to be specified in the https.request method. But since you also don't allow a proxy to be specified in the options, I don't see any reason at the moment to add the agent option.

2) commit a timeout to be specified (in milliseconds). On timeout of the https.request, the request will be destroyed and the promise will be rejected with a meaningful error. Since that might be useful, I have added that to your configuration node:

image

By default (and for older nodes) this timeout is 0, which means that I don't pass it in the options.

Some remarks:

So no major changes. Your node now still works fine in my setup...

Thanks for reviewing!! Bart

webmaxru commented 3 years ago

Published! Thank you for contribution!