search

webmd-health-services / GitAutomation

PowerShell module for libgit2
Apache License 2.0
27 stars 10 forks source link

Addressing Issue #32 and some minor details #33

Closed thorbenw closed 5 years ago

thorbenw commented 5 years ago

❌ 5bee2e2 Proposes a logging adjustment for execution in Azure Automation in the Module Manifest

thorbenw commented 5 years ago

@DecoyJoe Thanks for reviewing!

The encoding of GitAutomation.psm1 was UTF-16 before and still is (I double checked that because this was actually what made me hesitate for several days to contribute - I finally forced my local git treating .psm1 as UTF-16 through local configuration because I assumed you did so as well and that UTF-16 encoding was intended).

I agree it should rather be changed to UTF-8 w/o BOM to make it look nice in GitHub - I've done so in multiple commits to separate the encoding change from the content change:

  1. Reverted content change while encoding is still UTF-16
  2. Changed encoding from UTF-16 to UTF-8 w/o BOM - and also w/o any further changes
  3. Reapplied the content change while encoding is already UTF-8

In the 3rd commit, you can see the change - however, due to the encoding having actually changed now, it is still shown as a binary-file-change in the PR, but at least this won't happen again in the future. I also made sure a UTF-8 encoded .psm1 file still works for PowerShell.

decoyjoe commented 5 years ago

Since we don't currently have PR builds enabled for this repository, I have pulled these changes down, ran all tests locally, and confirmed all tests pass. PR is good to merge.