webmetrics / browsermob-proxy

NOTICE: this project has been forked and is being maintained at https://github.com/lightbody/browsermob-proxy
https://github.com/lightbody/browsermob-proxy
Apache License 2.0
232 stars 763 forks source link

As a general purpose proxy, we shouldn't limit the number of connections to emulate Firefox 3. #110

Open nirvdrum opened 11 years ago

nirvdrum commented 11 years ago

I think this one is pretty safe, but I wanted another set of eyes before I blindly merged it.

lightbody commented 11 years ago

I agree this code isn't correct, but I think the real fix is to also expose control over this behavior out via an API to BMP. Are you at all inclined to do that part too before I merge it in? :)

nirvdrum commented 11 years ago

Are you thinking each proxy would allow its own connection limit? Or would it be a global limit across all proxies? If the latter, which likely makes the most sense, I'd rather just do it as a startup param. But I could be persuaded otherwise. I just don't want to overly complicate things and my guess is most BMP users are now Selenium users, who are going to have their limits imposed by the client or grid, more than anything else.

lightbody commented 11 years ago

Yes, I think that we should allow the configuration on a per-proxy basis, since that's how all the other configuration is done (interceptors, bandwidth simulators, host mappings, etc). I'm also open to a "global config" concept that would apply for all configuration items, but that's kind of a separate feature.