search

webmin / authentic-theme

Official theme for the best server management panel of the 21st Century
https://authentic-theme.com
MIT License
947 stars 163 forks source link

Add 'required' attribute to login #1672

Closed PitWenkin closed 1 year ago

PitWenkin commented 1 year ago

I think this is the right place to make Webmin/Virtuamin loginfields required, to prevent submitting a login without username and/or password filled out?

https://github.com/webmin/authentic-theme/blob/9535b5915142f2b26f8a1c3212de47b4e904b524/session_login.cgi#L170 https://github.com/webmin/authentic-theme/blob/9535b5915142f2b26f8a1c3212de47b4e904b524/session_login.cgi#L183

I hope that there is no use-case where passwords are empty … 

iliajie commented 1 year ago

Hello,

No, it is not. Because technically it's possible to set Webmin password to blank and login with no password. It is a very bad idea (leave the password empty) but it is possible.