webmin / authentic-theme

Official theme for the best server management panel of the 21st Century
https://authentic-theme.com
MIT License
948 stars 164 forks source link

Webmin cannot be installed as an APP from the login screen #1687

Closed shoulders closed 9 months ago

shoulders commented 9 months ago
SYSTEM INFORMATION
OS type and version Ubuntu Linux 22.04.3
Webmin version 2.105
Usermin version 2.005
Virtualmin version 7.8.2  
Theme version 21.09.5
Package updates 19 package updates are available

Background

Through chrome on an android phone you can install websites as apps on your phone (very handy) if it has a proper manifest file and an appropriate declaration in the html.

The Issue

In authentic-theme/webmin you cannot add webmin as an app from the login screen which is the first place you would land before adding webmin as an app, but you can add webmin as an app once you have logged in.

Proposed Solution

Allow users to add Webmin as an APP at the login screen by doing the following

Why

If I could not add a website as an APP before I logged in, I would not expect it to allow you to add it as an APP after you login.

This is a very useful feature and is becoming more popular.

Related Issue

iliajie commented 9 months ago

Hello,

Thanks for the heads up! Although, this is already possible, e.g.:

image

However, you won't see this button unless you have legit (not self-signed) SSL certificate installed for your domain.

shoulders commented 9 months ago

:smile: the issue is that it cannot be done from the login screen, the code is missing. People (like me) might not figure this out. Normally this feature is not behind a credential wall, login comes after installing the app.

image

Thanks for the heads up on requiring a real SSL.

iliajie commented 9 months ago

Alright, thanks! Fixed on the latest commit!