webmin / authentic-theme

Official theme for the best server management panel of the 21st Century
https://authentic-theme.com
MIT License
948 stars 164 forks source link

uptracker.cgi displays HTML in size field #1692

Closed michaelbaisch closed 8 months ago

michaelbaisch commented 8 months ago

Hello,

I've noticed an issue where uptracker.cgi is used, specifically an unintended display of HTML tags in the size field. This issue can be observed in various contexts, such as when uploading a package in the software module or using an upload parameter in a custom module. It's most easily visible with larger files, as the pop-up window remains open for an extended period. I'm opening an issue here because this does not occur with the gray theme, but it does with the authentic theme.

Screenshot 2024-01-16 at 10 07 30 Screenshot 2024-01-16 at 10 08 43

I suspect that theme_nice_size_local outputs the size with span tags, and in uptracker, these tags are escaped here.

Greetings

iliajie commented 8 months ago

Hello,

Thanks for the heads up! The problem is actually that the theme did't fully replace uptracker.cgi upload tracker.

The latest commit adds support for it.

Example:

image

image

michaelbaisch commented 8 months ago

Awesome, thanks!