search

webmin / authentic-theme

Official theme for the best server management panel of the 21st Century
https://authentic-theme.com
MIT License
950 stars 164 forks source link

CSS source code and build instructions for MIN files #1696

Open verne-work opened 2 months ago

verne-work commented 2 months ago

from https://forum.virtualmin.com/t/location-of-css-source-code-and-how-to-rebuild-min-css-files/119253

I have found many xxxx.min.css and xxx.min.js files in various folders – is it possible to view and download the source of these for analysis and education, as well as obtaining the build instructions – so I can roll my own custom version? While it is possible to read the MIN versions, its hard.

Sorry if its here in github and I simply missed it 😄

iliajie commented 2 months ago

I haven't had the chance to work on and release the source version of the Authentic Theme yet. Initially, I aimed to do this once it reached 1k stars on GitHub, but we're not there yet. 😄

Releasing the full source is indeed time-consuming. It involves adding numerous comments and making additional refactors for clarity. Additionally, the build scripts are quite complicated and would require further explanation. It's essentially a whole project on its own.

chriswheeler commented 1 month ago

+1 to this.

It would be nice to see the source so that any changes can be reviewed and people can contribute more easily.

I aimed to do this once it reached 1k stars on GitHub, but we're not there yet.

That's a bit of a catch-22. Without people being able to contribute, they are less likely to star the repo. Having said that, I've just starred it, and it's on 947 stars now.

It involves adding numerous comments and making additional refactors for clarity.

Would it not be better to make the source code available and then refine it and make it easier to contribute to?

If anything, this should be the other way around. The source files should be in git and the minified versions excluded from git, as artifacts of a build process.

Some parts do have .src files available - e.g. /extensions/stats/stats.src.js - what is the downside to making these available for all parts?

Keep up the good work :)

iliajie commented 1 month ago

Would it not be better to make the source code available and then refine it and make it easier to contribute to?

Thanks, I will look into it in the future.

Some parts do have .src files available - e.g. /extensions/stats/stats.src.js - what is the downside to making these available for all parts?

Stats are relatively new, just like Mail, and have been open for contributions for the past six years. However, I haven't seen anyone making any contributions.

If anything, this should be the other way around. The source files should be in git and the minified versions excluded from git, as artifacts of a build process.

Well, historically, we supported upgrading from the Authentic theme Git repository.