webmin / authentic-theme

Official theme for the best server management panel of the 21st Century
https://authentic-theme.com
MIT License
948 stars 164 forks source link

Extra entries - Allow beautiful JSON #1701

Closed shoulders closed 2 months ago

shoulders commented 2 months ago
SYSTEM INFORMATION
OS type and version Ubuntu Linux 22.04.4
Webmin version 2.111
Usermin version 2.010
Virtualmin version 7.20.2  
Theme version 21.10
Package updates All installed packages are up to date

background

in Theme configuratcion --> Configuration category: Naviagtion mneu --> Extra entries: you can defined your own menus.

image

image

the issues

Proposed solution

A beautiful JSON is much easier to read and manipulate

A beautiful JSON

{
  "extra": [
    {
      "title": "Google Mail",
      "link": "https://gmail.com/",
      "icon": "google",
      "level": "0,1,2,3,4"
    },
    {
      "title": "BIND DNS Server",
      "link": "/bind8",
      "icon": "server"
    },
    {
      "title": "Usermin",
      "link": "/",
      "icon": "envelope",
      "port": "20000",
      "target": "_blank"
    }
  ]
}

additional

the example in the tool tip is perfect, it has the right balance of the different options you can configure

iliajie commented 2 months ago

Thanks for the heads up!

That is fixed now! I have also added validation for the passed data, so it won't break the theme config completely.

shoulders commented 2 months ago

thanks @iliajie , this is one I really wanted, I cant tell you why, but I appreciate it.

iliajie commented 2 months ago

You're welcome!