webmin / authentic-theme

Official theme for the best server management panel of the 21st Century
https://authentic-theme.com
MIT License
947 stars 163 forks source link

Theme: Install module popup page not displaying the page scroll #433

Closed hasanalsamra closed 8 years ago

hasanalsamra commented 8 years ago

Hi, I was trying to install a module to webmin from Third party modules but the problem is that i cannot scroll down because of hidden scroll to see another of modules. I just bypass it with temporary removing the overflow: hidden; in your css. Thx, Great updates!

iliajie commented 8 years ago

Hi,

I have done some changes in this regard. It should work. In case it still doesn't work for third-party module, make sure adding it to the Modules to exclude option on the theme settings.

iliajie commented 8 years ago

Please upgrade to 17.83.

hasanalsamra commented 8 years ago

LOL, Yes the third parties page solved but the standard webmin modules still has the issue

hasanalsamra commented 8 years ago

But thx anyway.

iliajie commented 8 years ago

What browser are you using? Do you open the module in the window or having left menu?

hasanalsamra commented 8 years ago

Chromium, it is a popup window: 1 2

iliajie commented 8 years ago

I see. I'll fix it on the next release.

hasanalsamra commented 8 years ago

Ok thx for your response.

iliajie commented 8 years ago

I will try to workaround all window.open events and turn it into beautiful modal.

I will not add this to 17.84 but most likely in 17.85.

hasanalsamra commented 8 years ago

yes, that will be better, you are the best thx

iliajie commented 8 years ago

Thank you for using my theme! :)

hasanalsamra commented 8 years ago

:) your theme is the best

iliajie commented 8 years ago

:+1:

humantex commented 8 years ago

Just to chime in... I've seen the same issue with almost every scrollable page that ends up as more than one screen high - even the deeper ones like hard drive smart-status reports, and the generated software updates/installs. It isn't just individual modules or functions for webmin / virtualmin / usermin. There's no way to see what specific errors were displayed for critical issues if it appears upwards in the page.

iliajie commented 8 years ago

Yes, it happens on the popup. I will migrate popups very soon. Meanwhile, make sure that you're using the latest 17.84.

iliajie commented 8 years ago

Will be fixed in 18.00.

Thanks for reporting.

hasanalsamra commented 8 years ago

Thank you man :+1: