search

webmin / authentic-theme

Official theme for the best server management panel of the 21st Century
https://authentic-theme.com
MIT License
947 stars 163 forks source link

Theme: Webmin API `ui_form_end` buttons not working #543

Closed KramNotlimah closed 8 years ago

KramNotlimah commented 8 years ago

I am writing a module for Virtualmin and I ran across an issue with the ui_form_end subroutine in the Webmin core API. If you open a popup window and use the popup_header instead of the ui_print_header the buttons all come out with a value="OK". In the original Virtualmin theme with the same code they came out with the correct values. When using the ui_print_header in the main windows the ui_form_end produces buttons fine in the original Virtualmin theme and in the Authentic Theme. It seems it is only an issue when using the popup_header with Authentic. I worked around the issue by just creating my own buttons but it would be nice to be able to use the API as advertised.

Mark

iliajie commented 8 years ago

Hi, Mark.

I will run tests a bit later and try fixing it upon next release.

KramNotlimah commented 8 years ago

Thanks. That sounds great.

Mark

iliajie commented 8 years ago

Mark, where could I test it in VM or WM?

iliajie commented 8 years ago

Ahh, ok, got it! It will be fixed in 18.20.

iliajie commented 8 years ago

Version 18.20 is out, please upgrade.

KramNotlimah commented 8 years ago

Thanks! I will get the update.

Mark