webmin / authentic-theme

Official theme for the best server management panel of the 21st Century
https://authentic-theme.com
MIT License
947 stars 163 forks source link

Pages not loading in Firefox #6

Closed h9k closed 9 years ago

h9k commented 10 years ago

When on the List Virtual Server page for example and clicking on a domain, the pages does not load in Firefox. The loading icon appears but nothing happens. No javascript error, no network activity in Firebug. Chrome and IE are fine.

iliajie commented 10 years ago
  1. What version of Firefox are you testing it on? I just tested it on Firefox 32.0.2 and it seemed to work perfectly fine? Try to double click with right mouse click on the loader, what do you get after all? Is it Edit Virtual Server title on top?
  2. Did you clear Firefox's cache after updating?
h9k commented 10 years ago

I tried on 32.0.3, now updated to 33.0.0, same problem. Cache is completely empty. When I double right click on the loader, it just shows the "List Virtual Servers" page again. I don't get any "Edit Virtual Server" title.

iliajie commented 10 years ago

I'm in Linux. I will try testing it in Windows and come back to you as soon as possible. This is very weird though.

h9k commented 10 years ago

I disabled all Firefox extension and it works. After reenabling one by one I found the addon that causes the problem: LastPass 3.1.54

iliajie commented 10 years ago

Oh, alright! Thanks for finding this out! I wonder what it has to do with our theme and listing virtual servers anyway!? ;)

I'm closing this issue then.

Cheers, Ilia

lnorbi commented 9 years ago

Actually this issue should not be closed, as it is NOT a LastPass issue. None of the content pages load properly if any plugin that tries to access the page content (like any password manager, LastPass, AI RoboForm, etc.) or FireBug/FF dev tools is active. To reproduce, just bring up the developer tools in Firefox and try to load any content page (e.g. User Mail -> click on any user). The loading indicator is shown, and remain there forever. The page content is not refreshed. I guess this has something to do with how the page load is handled, Firefox does not acknowledge the updated content.

Other themes in Webmin does not have the same problem, so it's definitely theme-related. This would be a great theme, but this single issue pretty much renders it useless for me, since LastPass cannot be disabled on a per-page basis.

iliajie commented 9 years ago

It's very weird and here is why! I could reproduce the error you were talking about but only with FireBug (in-built dev tools console worked always fine). After I could reproduce it with FireBug, I found that FireBug was complaining to jQuery itself. After I resaved the file the error disappeared. Hard to tell what exactly was it.

Try replacing /authentic-theme/unauthenticated/js/jquery.min.js and with re-downloaded http://code.jquery.com/jquery-2.1.1.min.js. Clear the cache afterwards.

Not sure it will work really. But after updating jQuery I coudn't reproduce the bug.

Keep me posted, please.

Thanks.

iliajie commented 9 years ago

Alright, figured out that setting in FireBug Script Panel to disabled makes things work correctly.

lnorbi commented 9 years ago

Replacing jquery does not help. Disabling FireBug script debugger works for FireBug-related issue, but still leaves the password manager issue unresolved. For whatever reason, when a password manager is enabled, pages do not load. I'm not sure what FireBug and a password manager has in common, I guess both try to access the page content somehow.

Can it be related to flagging/invalidating the updated page content, so that these plugins are re-triggered by the browser? I guess they access page content and flag it somehow so that the browser believes it is final. Then, the script loads the fresh content from the cgi, but the browser does not recognize it should be redrawn. (If I right-click on any of the content links and choose Open in new tab, the content loads properly, so indeed the content is coming from the server, it is just not recognized by the browser and not drawn on the page.) Maybe cache control directive on the page coming from the server... ?

h9k commented 9 years ago

I think this issue should be left open. There is definitely an issue with some Firefox plugins, and it is more likely that the problem resides somewhere in the theme itself rather than in the plugins. For instance, with LastPass I never had any similar problems with any website for years.

iliajie commented 9 years ago

Dear guys, I understand what you are saying.

On my side. I see no real reasons for Authentic Theme to fail when some Firefox modules are on. The theme uses very tricky/complicated algorithms to make the whole thing work. There are a lot of setTimeOut functions. I could think it's what is causing the issue but I'm not sure. I can't reproduce the bug, when using in-built Firefox console - everything just works fine. When installing FireBug and enabling Script Mode, then yes, it fails - but again why it's not the plugin itself? Just because you don't experience it on some other site, well maybe and at the same time, maybe not.

If you could debug it for me and come up with some concrete suggestions, I could do something sooner but so far, I will put this off and only keep in mind, for the future development.

h9k commented 9 years ago

Ok, I will have a look at it when I have some time and see if I can find something out and let you know.

iliajie commented 9 years ago

Thanks

sykezz commented 9 years ago

I've got the same issue too. Got both LastPass and Firebug installed.

PartisanEntity commented 9 years ago

Hello, I have the same issue. I too have LastPass and Firebug installed.

I get the loading circle going on forever when I try to call up the page to manage the themes for example.

At the same time a huge thank you to qooob and others, beautiful theme and really brings webmin into the 21st century :)

iliajie commented 9 years ago

Thank you for your kind words, my friend!

I'm going to keep improving the theme. Though, I can't promise that I will fix the current issue by the next, on-going 7.0.0. release but I will try. If you guys (people from this thread) could report it to the developers of LastPass/Firebug, probably it would speed up the change. For now, I would deeply recommend trying Authentic Theme in Chrome browser and I bet you would enjoyed it most of all.

Thank you for using Authentic Theme! ;)

mpkossen commented 9 years ago

I also have the issue and I also have LastPass installed. I'm not married to Firefox, but it is my preferred browser and I am a bit of a fanboy ;-) So, as a work-around I'm fine with using another browser.

If there's anything I could do to help diagnose this issue further, please let me know.

@qooob: Thank you for the awesome theme!

iliajie commented 9 years ago

@mpkossen, thanks. If you could find out the reason why is this happening and report here, I could try fixing it then. Script also fails to work in the latest Internet Explorer and return an error. It could be connected. I will do it myself, sooner or later, when I have more free time.

iliajie commented 9 years ago

I think I have found the solution, finally. It works! :) New Authentic Theme, version 7.0.0. will bring you not onl, much better UI experience but also let you keep your favorite plugins (I believe I really fixed that).

I will close this issue for now and after update to 7.0.0. you are free to open it again if it doesn't work.

Thank you for reporting bugs.

h9k commented 9 years ago

I'm afraid I need to reopen this issue. Currently running version 8.1.0. I cannot even change the theme back to Virtualmin Framed, need to do that in another browser.

iliajie commented 9 years ago

Have you just updated or it stopped working recently? Why it doesn't work only on your system? What makes you think that it's Authentic Theme problem and not on your side?

iliajie commented 9 years ago

Version 9.0.0. will have complete base re-write. I bet it will work with your last-pass plugin.

Please let me know if it is, when update is ready.