search

webmin / authentic-theme

Official theme for the best server management panel of the 21st Century
https://authentic-theme.com
MIT License
947 stars 163 forks source link

Theme: Virtualmin password recovery #646

Closed ai-hosting closed 7 years ago

ai-hosting commented 7 years ago

When using Virtualmin Password Recovery and Version 18.30-18.32 the login url for Version 18.30-18.32 is missing at the main page. Works with other themes.

iliajie commented 7 years ago

Hi,

It's not missing. Have a look at the screenshot. screenshot from 2017-01-14 15-01-20

ai-hosting commented 7 years ago

old theme

iliajie commented 7 years ago

I know about that text link. We decided to move it to the button.

Maybe the text should be a bit more clear.

ai-hosting commented 7 years ago

new theme

Missing at 10 different servers when using authentic-theme and centos 7

iliajie commented 7 years ago

Could you please click Reset orange button!?

jobhh commented 7 years ago

To be honest, it also is not clear to me that the Reset button is (or should be) a reset password button. It only seems to empty the Username and Password fields.

iliajie commented 7 years ago

What would be the good name? Password reset?

jobhh commented 7 years ago

If that is what it does, yes. But currently it only seems to clear the Username en Password fields on Firefox and Chrome on Windows 10. Didn't test any other browser.

Server is running latest Webmin/Virtualmin running on Debian 64bit.

iliajie commented 7 years ago

Missing it? Do you have Virtualmin password recovery installed? As far as I remember it requires it to be installed in order to work.

jobhh commented 7 years ago

I never heard of the module, so I don't have it installed :p I also cannot find it inside Webmin/Virtualmin as an unused module. The only way to get it seems to be from here http://www.webmin.com/cgi-bin/search_third.cgi?category=Virtualmin.

Maybe the theme shouldn't show the Reset (password) button if the required module is not installed, since the function of the button without this module is a bit unclear. I assume this lead to @ai-hosting opening this issue.

iliajie commented 7 years ago

Reset button is not needed, I agree. I will see what I can do here.

ai-hosting commented 7 years ago

if Virtualmin Password Recovery is installed RESET will take you to the pass recovery url. Only problem is that is doens't support real password reset. If virtualmin allows plain text password storage it will send the old password by email. A smart admin will store the password in a hashed form. Making the Virtualmin Password Recovery unusable.

iliajie commented 7 years ago

@ai-hosting Even though I agree, that is not the theme issue. Report it to Webmin repo.

iliajie commented 7 years ago

What are we talking here? I'm not sure.

I will remove reset button as it's useless. But if you have VM password recovery does it work the same way for you as in old themes?

iliajie commented 7 years ago

.. I will call the new button for Password recovery as such.

iliajie commented 7 years ago

Oh, yeah. Don't bother. I see what you mean. I will make a quick fix for you to check.

iliajie commented 7 years ago

Please have a try this patch.