webmin / authentic-theme

Official theme for the best server management panel of the 21st Century
https://authentic-theme.com
MIT License
951 stars 163 forks source link

Theme: Broken automatic update (404 error) #787

Closed TopheC closed 7 years ago

TopheC commented 7 years ago

Hello,

I was unable to update, as usually, from previous version 18.48 of the theme. My browser fired a 404 from github. Same problem of bad url from the download link on readme.md !

I saw a "-2" on the next version name in my Webmin Dashboard panel, so i try to install the new theme version from the "install theme" tab with this url : https://github.com/qooob/authentic-theme/releases/download/18.49/authentic-theme-18.49-2.wbt.gz I just add "-2" to the name and before extension.

Maybe help some folks :-)

jvieille commented 7 years ago

Something is wrong with this update. Latest available release 18.49-2 does not proceed

iliajie commented 7 years ago

I'm sorry, guys, my bad. I didn't add 18.49 as a release package but only 18.49-2. Now it's going to work. Please try.

jvieille commented 7 years ago

Same:

iliajie commented 7 years ago

Oohh. Yeah. The only way to overcome this right now is to go to theme settings and force update the theme.

I was going to enroll this feature for a long time but it happened to be back-incompatible.

In case Git command is installed force update button will appear in theme settings and will let you update very easily.

jvieille commented 7 years ago

How do I install Git command? thanks

iliajie commented 7 years ago

I think apt-get install git or using Webmin packages module.

Infowan commented 7 years ago

TopheC's method solved my problem. All servers up to date. Thak you TopheC!

jvieille commented 7 years ago

TopheC' method was simpler. thanks

TopheC commented 7 years ago

@jvieille and @Infowan, glad it helps you :+1: @qooob , maybe some new lines on the "Troubleshoot" section of the readme.md, if you please ?

iliajie commented 7 years ago

Thank you, but I don't think it's necessary as this will be resolved very soon with next Webmin/Usermin release. It's only applicable to the users that missed 18.49 update.

Besides, there is a section explaining how to update the theme manually, using console script. :wink:

TopheC commented 7 years ago

Ok, it's my ITIL Knowledge Management side : a bug > a known error > a solution > known errors database (aka FAQ) updated with the solution > available publicly... you're the boss :wink:

Francewhoa commented 7 years ago

We are confirming this bug. It is recurring every few release. Each time that bug happens users are not able to update using the interface.

Steps to reproduce bug

  1. Using:

    1. Operating system Debian Linux 8
    2. Webmin version 1.840
    3. Virtualmin version 5.07
    4. Theme version Authentic Theme 18.48
  2. Go to Virtualmin dashboard page, under "Theme version" row, click on that "Update" button.

  3. That red progress bar will be display at the top of the page

  4. The user is automatically redirected to Virtualmin dashboard. The updated failed. The version is still Authentic Theme 18.48. Expected result is the theme should automatically be updated and a overlay window should be display titled "Update Notice".

Screenshots

dashboard---screenshot---466

progress---screenshot---467

iliajie commented 7 years ago

Yes, it's already fixed in 18.49+. Update manually or forces-update from theme's settings.

Francewhoa commented 7 years ago

EDIT: Please ignore this comment. We doubled check and it does not work. This workaround by clearing the cache does trigger an update, then at the end returns a window titled "Update Notice". It looks like the update was successful. But in fact the update failed and the theme is not really updated. It's the same version. For us only the manual update worked so far.

For those presently using the theme version 18.48. But not using manual update, not using forces-update, and not using command line nor Git. Here is an easy and quick fix that worked for us. Using only the Virtualmin interface simply clear the theme cache, then try to update again. It usually works. Details below.

Temporary fix workaround

Steps

  1. Using Virtualmin dashboard page, under "Theme version" row, click on "Options" button
  2. The next page is titled "Webmin Themes". Scroll all the way down that page. Click on "Clear cache" button.
  3. Go back to Virtualmin dashboard page, under "Theme version" row, click on "Update" green button
  4. When done an overlay window will open. Titled "Update Notice". Done you have successfully updated the theme. That workaround does not always work though.
Francewhoa commented 7 years ago

@qooob :) Thanks for your reply

Yes, it's already fixed in 18.49+. Update manually or forces-update from theme's settings.

That sounds great. But users with the theme version 18.48 do not see the force update button. And manual update is out of reach for some user presents skill. For example at Ubertus our team of System Administrators is composed of both juniors and seniors. The junior level are involved with junior projects, they are able to use the Virtualmin interface only. Command line/Terminal, Git, or download and uploading theme files is presently too challenging for them.

Suggested improvement

Here is a suggested improvement. If not already done, on Virtualmin dashboard, when the user click on that "Update" button, before starting the update process, we suggest to automatically clear the theme cache, then proceed with the theme update process. That would reduce risk of future broken automated updates.

This suggestion is related to my comment above at https://github.com/qooob/authentic-theme/issues/787#issuecomment-303549882

rstiger commented 7 years ago

Yep I'm having the same problem updating theme I'm getting 404 error. I tried clearing the cache as suggested by Francewhoa but no luck. Operating system Ubuntu Linux 14.04.4 Webmin version 1.840 Virtualmin version 5.07 Theme version Authentic Theme 18.48. Latest available release 18.49-5 Update Changelog Download Options Time on system Tuesday, May 23, 2017 7:49 PM Kernel and CPU Linux 3.13.0-119-generic on x86_64 Processor information Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, 4 cores

I guess I will either install manually or just wait see...

rstiger commented 7 years ago

ok so I waited long enough and just manually installed and we are now up to date.

I went ahead and download the update from- https://github.com/qooob/authentic-theme/releases/download/18.49/authentic-theme-18.49-5.wbt.gz

And then installed theme from upload.

Operating system Ubuntu Linux 14.04.4 Webmin version 1.840 Usermin version 1.710 Virtualmin version 5.07 Theme version Authentic Theme 18.49-5 Time on system Tuesday, May 23, 2017 7:59 PM Kernel and CPU Linux 3.13.0-119-generic on x86_64 Processor information Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, 4 cores System uptime 1 hours, 24 minutes Running processes 214 CPU load averages 0.00 (1 min) 0.01 (5 mins) 0.05 (15 mins) Real memory 3.77 GB total / 1.45 GB used Virtual memory 7.81 GB total / 0 bytes used Local disk space 241 GB total / 195.25 GB free / 45.74 GB used Package updates All installed packages are up to date

I'm up to date now but others using the "Update" button might have same previous issues till it's fixed

mat-l commented 7 years ago

Clear cache didn't work for me, but the manual upload was working fine here 👍

Francewhoa commented 7 years ago

We're confirming the "Force update theme" button is now display with today latest Authentic Theme version 18.49-6 Yay :) force-update---screenshot---ubertus---018

Vitusware commented 7 years ago

I don't have a "Force update theme" button..

I still have Authentic Theme 18.48, whatever I try, I keep getting the 404 error.. "this is not the page you are looking for" :(

Is there another link I can use to update? and how to update manually?

johnnyaston commented 7 years ago

I have the "Force update theme" button but it still doesn't work. I would run a manual update but I'm having problems with this also.

iliajie commented 7 years ago

From 18.48 you would need to run second option, which still will update you with the release.

To see this button you need to install Git command.

Vitusware commented 7 years ago

Total noob here :D

so how do I do that ? ( install Git command.)

johnnyaston commented 7 years ago

Thanks qooob, yes I have Git command and the button is showing. I tried the second option and it reports that the update was successful - but it turns out not to be the case.

iliajie commented 7 years ago

To update the theme using package and get update-script.sh pulled to the latest use the package updates.

Go to Webmin/Webmin Configuration/Themes/Install Theme/From ftp or http URL, check the radio-button, paste the following link and hit Install Theme

http://github.com/qooob/authentic-theme/releases/download/18.49/authentic-theme-18.49.wbt.gz

johnnyaston commented 7 years ago

Great thanks qooob, that worked for me! All of the previous links mentioned were doing a 404.

iliajie commented 7 years ago

Yes, there was back-incompatible change. Sorry.

Vitusware commented 7 years ago

Thank you qooob, that worked perfectly, good support thank you! image

pieter-groeneweg commented 7 years ago

I have a button to force install.. I am on 18.48. After clicking the force install, The announced version update changed from 18.49-1 to 18.49-7... And I am still on 18.48

iliajie commented 7 years ago

Follow these instructions https://github.com/qooob/authentic-theme/issues/787#issuecomment-304617121

pieter-groeneweg commented 7 years ago

That works. Thanks