Theme: Authentic Theme moving to the next level with 19.00+

iliajie commented 7 years ago

Hi,

I have just added Authentic Theme 19.00-RC1.

gnadelwartz commented 7 years ago

in my setup only the webmin categorie modules was working, but e.g. Apache module and all others gave me an error like /usr/libexec/somecgi.cgi..../apache not found. note the 4 dots.

additionally the system timeon dashboard is shown twice

so i reverted to 18.49-8

iliajie commented 7 years ago

Hi,

Are you behind proxy?

gnadelwartz commented 7 years ago

of course 😎, but can't test non proxy because i'm on vacation and have only my tablet with me

Tantawi commented 7 years ago

I have the second issue (system time showing twice on dashboard, one linking to /time and the other beside it in black, none linked), plus:

1- Checking for packages updates by clicking the refresh icon on the dashboard does nothing, no errors in console and no Ajax requests are made.

2- If I click on "All installed packages are up to date" and click on "Refresh available packages" button, it works but the browser moves to "/package-updates/update.cgi?mode=updates&search=&refresh=Refresh+Available+Packages" and the side menu disappears.

3- System -> Software packages -> "Search for package:" does nothing again, no console errors or AJAX requests made.

This is tested on Chrome Dev 61 on Windows 10 and macOS, without any proxies or VPNs.

Otherwise, this is almost perfection! :)

iliajie commented 7 years ago

Mohamed, hi!

Thank you for your comments. I'm aware of those problems. At the moment, I need to find out how to get progressive output using jQuery.

There are other issues with File Manager and ConfigServer Security & Firewall modules. They don't work as SPA yet. There is so much code to review/rewrite.

I'm working on it ..

I'm looking forward (eager really) to start enrolling new features but I'm stuck with this stuff. (but I find this vital, so I'm not really complaining.. just has to be done..)

tpnsolutions commented 7 years ago

Another cosmetic issue I just discovered in RC1.

When you create a "Virtual Server", the left and right sidebars disappear.

iliajie commented 7 years ago

You mean you are taken to the separate page? Well yes, RC1 doesn't have progressive output support.

Thanks Peter for looking into it.

iliajie commented 7 years ago

RC Release Notes:

Version 19.00-RC2 (July 31, 2017)

Added support for proressive output (buffered header)
Added system information is now being recollected using native recollect.cgi script
Fixed theme post save actions to refresh navigation menu properly on server request
Fixed failed to load modules that can accept multiple methods, for example Command Shell
Fixed navigation menu detection for module configuration pages
Fixed pie-chart displayed incorrectly after going to theme's settings #825
Fixed time displayed incorrectly on System Information page #825

tpnsolutions commented 7 years ago

# 19.00-RC2

This is just a cosmetic issue, likely an oversight and pretty minor.

When you click "Logs and Reports > Apache Error Log" the left navigation highlights "Apache Access Log".

This is just a cosmetic issue, likely a simple fix

When you click "Logs and Reports > Apache Access Log", the page show a clean, themed log entry text area.

on-load view-logs

However, when you click the "refresh" button on the page, it seems to lose it's styling.

on-refresh view-logs

This is a possible improvement to the "Logs and Reports" area

Instead of having to "manually" refresh the pages, wouldn't it be nifty to have say a "start" and "pause" button where you could asynchronously refresh the log in near real-time similar to issuing a "tail -f" on the command line. The purpose of having a "start" and "pause" button is so people can still decide whether they want to monitor the log, or simply see the last X amount of lines.

iliajie commented 7 years ago

Yes, I like this idea so much. I will add this toggle. .. and fix the bug..

..please, please - keep digging. I need it.

Tantawi commented 7 years ago

Great progress! thanks a lot. One cosmetic bug in RC2, Chrome v61 on Windows 10:

1- My server is running Ubuntu 16.04 and I have installed smartmontools package (to display hard drive temps on dashboard, I have three). 2- Upon login, or manual page refresh on the dashboard, "Drive temperatures" will flash for a split second then disappear. 3- Clicking the Dashboard icon from the navigation will make Drive temperatures display and stick, as normal.

iliajie commented 7 years ago

Thanks, I will fix it all in RC3.

Tantawi commented 7 years ago

One more error: Trying to set auto checking for packages updates to every hour, entering an email for reporting, and choosing "Install any updates", then clicking "Save" outputs a lot of JavaScript errors in the browser console and nothing is saved.

iliajie commented 7 years ago

Thanks @Tantawi I will take a look! :wink:

iliajie commented 7 years ago

RC3 is available. Please give it a try!

@tpnsolutions Peter, new features with log auto-update will be enrolled later. It's on my to-do.

iliajie commented 7 years ago

Nothing to add or say about RC3? :wink:

tpnsolutions commented 7 years ago

@qooob just installed RC3.

Started to navigate to each of the pages in the UI, and came across the first bug.

"Webmin > Others > File Manager" takes you to a "separate page" without the basic UI wrapped around it.

tpnsolutions commented 7 years ago

@qooob another bug, related to former.

"Virtualmin > Edit Web Content" opens in "new tab" and "separate page" without basic UI wrapped around it.

underlying issue appears to be related to "Filemin" integration

tpnsolutions commented 7 years ago

@qooob another bug found.

"Virtualmin > Logs and Reports > Apache Error Log" triggers "Apache Access Log" to be highlighted in left menu instead of "Apache Error Log".

tpnsolutions commented 7 years ago

@qooob another bug, related to former.

"Virtualmin > Services > Configure Website for SSL" triggers "Configure Website" to be highlighted in left menu instead of "Configure Website for SSL".

iliajie commented 7 years ago

Thanks, Peter. File Manager is still not working in RC3.

About Error Log and Website for SSL not being highlighted - confirmed.

gnadelwartz commented 7 years ago

When do you expect to have a working File Manager?

iliajie commented 7 years ago

I'm working on it right now. 😉

iliajie commented 7 years ago

Version 19.00-RC4 is out (August 31, 2017).

Added history native API support
Added support for File Manager
Added support for ConfigServer Security & Firewall (in separate tab so far)
Added Virtual Server Summary link for Virtualmin
Fixed all modules opened in single frame to have no offset and padding
Fixed HTTP Tunnel module to work correctly
Fixed bugs #53082 #53174

Please give it a try. Looking forward for your comments.

_* Note: RHEL and FreeBSD complained about cache on my machines._

iliajie commented 7 years ago

Version 19.00-RC5 (September 01, 2017)

Fixed upcoming bugs

Tantawi commented 7 years ago

Thanks for the updated release. One bug in RC5:

Click "Refresh Modules", it works but the left menu disappears with only a spinning loading icon. (Chrome Dev 62 and Firefox 56 on macOS)

iliajie commented 7 years ago

That is strange as I couldn't reproduce it.

Could you please hard reload Chrome's cache and try again?

Tantawi commented 7 years ago

I did, same result. Also tried an incognito window, same. My server is running Ubuntu 16.04.3

Oh, I am running webmin behind an Apache proxy... can this cause it?

iliajie commented 7 years ago

Oh, yes. It could. I just fixed proxy bug for RC6. I will check, now it's clear, thanks.

Tantawi commented 7 years ago

Thanks, I remember for the brief moment RC4 was available, I had this bug widely in every page :) but it was fixed quickly with RC5.

gnadelwartz commented 7 years ago

Ah, then I wait until RC6 ;-)

Am 4. September 2017 1:50:37 Nachm. schrieb Ilia Rostovtsev notifications@github.com:

Oh, yes. It could. I just fixed proxy bug for RC6. I will check, now it's clear, thanks.

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/qooob/authentic-theme/issues/807#issuecomment-326943391

iliajie commented 7 years ago

RC6 fixes all found bugs related to proxy configurations.

Please give it a try.

Tantawi commented 7 years ago

Just did with emptied cache, still have the exact issue with menu when refreshing the modules, and now another bug: The default Roboto font is not loading, instead everything is displayed in a Serif font. Other font options work fine though, just not the default.

Edit: debugging the issue I see a 404 error on this file: https://webmin.xxxx.xxx/unauthenticated/css/fonts-roboto.min.css?1900RC6

I noticed you fixed another bug with refreshing the system information page, thanks! 👍

iliajie commented 7 years ago

Oh, right. I see the cause of the issue with fonts. My compiler deleted its lib. WIll be fixed in RC7.

I can't reproduce Refresh Modules bug. It woks fine on all systems, have a look:

Video-screencast

I would need more info in case it still fails to work. Open console in Chrome. What's it showing?

Tantawi commented 7 years ago

hmm, the console looks fine:

GET https://xxxxx/unauthenticated/css/fonts-roboto.min.css?1900RC6 net::ERR_ABORTED bundle.min.js?1900RC6:116 Running authentic.js - LEFT bundle.min.js?1900RC6:116 Welcome to Authentic Theme 19.00-RC6 https://github.com/qooob/authentic-theme

One more comment about the 404 error on the css file, I get a lot of other 404 errors on the login page as well making it looks broken, but i can still login:

bootstrap.min.css?1900RC6 fontbase.min.css?1900RC6 authentic.min.css?1900RC6 fonts-roboto.min.css?1900RC6 jquery.min.js?1900RC6

Any specific info I can provide that might help debugging the other issue? I only have access to browsers on macOS now but will have Windows access in a few hours.

iliajie commented 7 years ago

Version 19.00-RC7 (September 05, 2017)

Fixed issue with missing dependencies on login page

I have fixed issues with missing dependencies in RC7.

Anyone reading this, can you confirm Refresh Modules Link causes navigation menu loading without stop?

iliajie commented 7 years ago

@Tantawi Try going to Theme Settings, then Force Update Theme and then install manually the downloaded package of RC7.

What your server OS?

Tantawi commented 7 years ago

Thanks for the rc7.

I did what you have suggested, no difference, still have the issue.

Server OS is Ubuntu 16.04.3 + 4.13 Kernel (but I just upgraded now from 4.12.10 it was the same).

Few things that might help:

I have some modules disabled (like Java File Manager).
I have renamed "MySQL Server" module to "MariaDB Server".
I have no browser extensions installed.
I am using https + h2 with the Apache proxy.
I have compression disabled in webmin config, because the Apache proxy will compress the output anyway.

Tantawi commented 7 years ago

I just tried to access webmin directly without the Apache proxy, (ip:port), and the issue remains...

iliajie commented 7 years ago

What happens if you run update_navigation_menu(-1)

iliajie commented 7 years ago

I've just updated RC7, re-download/install please and try again.

It might fix your issue.

Tantawi commented 7 years ago

The updated RC7 still have same issue. Running the command you posted in the console made the menu text turns to a spinner (produced the bug) and gave me this in the console:

update_navigation_menu(-1) undefined

Tantawi commented 7 years ago

@tpnsolutions Can you please share your experience refreshing the modules in the latest RC7 to see wether you have the same bug as mine or if it is an isolated issue? much appreciated.

iliajie commented 7 years ago

Hi,

I just released RC8, try it guys.

@Tantawi Please try to share debugging info, from Network tab of the console in case it still doesn't work for you. I couldn't reproduce it on any of my machines (4+).

gnadelwartz commented 7 years ago

Hi, now I found time to test RC8. In the first place main things seems to work. Somtimes it takes long to load a module for first time, but all my mainly used modules seems to work.

So far I found only two Issues in the reworked majordomo module:

the global configuration button circles forever and edit_global.cgi is not loaded.
the red loading indicator also stay forever
the edit icon on the main screen is not shown anymore, only the edit textlink for non authentic themes. here is the code I used to replace the edit textlink with an icon if authentic theme is used:

print "<script>",
        "f__lnk_t_btn(['/majordomo/', '/majordomo/index.cgi'], 'table tbody td',",
        " 'a[href*=\"edit_info.cgi?\"], a[href*=\"edit_members.cgi?\"], a[href*=\"edit_subs.cgi?\"],",
                " a[href*=\"edit_mesg.cgi?\"]',",
                " 'btn btn-transparent btn-xs vertical-align-top margined-top-2', 'fa-edit');",
        "document.querySelectorAll('tbody td .btn.btn-transparent').forEach(function(button) {",
                " button.innerHTML=button.innerHTML.replace(/<\\/i>.*edit/,'');});",
        "</script>",
        "<style>.btn.btn-transparent { padding: 0 !important; color: grey;}</style>";

I know, this should be done by theme ... I'll be glad if you can do it in 19.0+ BTW: If I disable the above code, the redloading indication works, but global config not.

majordomo with with regular authentic theme:

majordomo original

majordomo with RC8

majordomo rc9

iliajie commented 7 years ago

What does this configuration button do? Is it stray button outside of the form element, meant to submit the form?

Where can I install this module from to test it?

gnadelwartz commented 7 years ago

the config button is a seperate form calling simply edit_global.cgi, soory to forget to attach the picture already taken: bildschirmfoto vom 2017-09-08 12-53-19

the reworked majordomo modul is a standard webmin module, but not installed in the standard distribution.

Description	Create and configure mailing lists for Majordomo version 1.94.
Download	http://www.webmin.com/webmin/download/modules/majordomo.wbm.gz
Website	http://www.webmin.com/webmin/standard.html
Author	Jamie Cameron
Last updated	2017-06-25 23:32:19

As always: Apache proxy setup

Tantawi commented 7 years ago

I found a bug with RC9 I think it is related to proxy config:

Go to Webmin Configuration --> Module Titles --> Try to rename any module and click "Save", I got a red error popup with this details:

Request URL: https://.../webmin/edit_descs.cgi?xnavigation=1...save_descs.cgi

Server response: 404/"error"

Response details: error: Error - File not found

Server OS: Ubuntu Linux 16.04.3

User agent: Google Inc./Mozilla/Netscape/5.0 (Macintosh; Intel Mac OS X 10_13_0) AppleWebKit/537.36 > (KHTML, like Gecko) Chrome/63.0.3213.3 Safari/537.36; cookieEnabled

Then If I click to return to Webmin configuration I move to this URL in the browser:

https://proxyURL/webmin/:10000/webmin/?xnavigation=1

Which works fine though. And the module is actually renamed as well.

Regarding my specific menu bug with forever loading I think you can ignore it as no one else have reported it, it might be my server though all XHR requests are finished with code 200 and no errors in console or anything. Really weird.

iliajie commented 7 years ago

Hi, I just tested it in RC10 and I don't see this happening.

Please upgrade, force-clear cache and try again.

Tantawi commented 7 years ago

Just tried RC10, same thing, confirmed that it only happens if I access webmin via Apache proxy, as direct access works fine without error message.

Update: So I had ProxyPreserveHost set to On on my Apache config, tried Off and it solved the issue. :)

webmin / authentic-theme