search

webmin / usermin

Usermin source code
http://www.usermin.com/
Other
126 stars 47 forks source link

Status mail wrong encoding #67

Open DrCarsonBeckett opened 3 years ago

DrCarsonBeckett commented 3 years ago

We're about to release Webmin 1.962 and Usermin 1.811, which are going to include these patches. Within few days, as you install updates, please come back to us sharing how it works for you.

Originally posted by @iliarostovtsev in https://github.com/webmin/webmin/issues/1272#issuecomment-725585499

I need to open another ticket for that too. I received a few mails and the issue is still there. It happens in different browsers (IE, Edge, Firefox, iOS Safari and iOS Firefox) as well on other PCs. It happens in Outlook and Thunderbird as well, the only mail app which displays it correctly for me is the iOS default Mail app.

System: Debian 10 Webmin-Version | 1.962 Usermin-Version | 1.812 Virtualmin Version | 6.14 Authentic theme version | 19.62

Edit: I opened the issue first in the webmin area and closed it (#1332), sorry.

iliajie commented 3 years ago

Hi,

How this issue is different from https://github.com/webmin/usermin/issues/66?

It happens in different browsers (IE, Edge, Firefox, iOS Safari and iOS Firefox) as well on other PCs. It happens in Outlook and Thunderbird as well

What happens?

I opened the issue first in the webmin area and closed it (#1332), sorry.

No problem, thanks!

DrCarsonBeckett commented 3 years ago

I am not sure if its related to that or if its something else. This is about the encoding in the mails and not on the website.

What happens? That the characters in the mail are getting displayed wrong.

This is what gets shown in the mails:

Backup ist komplett. Die Gesamtgröße beträgt

Which should be displayed as:

Backup ist komplett. Die Gesamtgröße beträgt

iliajie commented 3 years ago

I am not sure if its related to that or if its something else. This is about the encoding in the mails and not on the website.

Considering it's generated by Virtualmin, it must be our bug, right @jcameron :slightly_smiling_face:

jcameron commented 3 years ago

Looks like our bug. Can you post the email here as an attachment, with all headers?

DrCarsonBeckett commented 3 years ago

I prefer not to do that due to the fact that data would be public then and I prefer that some of them are not. I can send them however via pm if that's somewhat possible.

iliajie commented 3 years ago

Yes, you can send it to me using my website's form. We will deal with it.

DrCarsonBeckett commented 3 years ago

I just sent it.

iliajie commented 3 years ago

This https://github.com/webmin/webmin/commit/1f9e4795caec8b332678beca2e25b809cddd41b2 should fix this. Could you test it please?

DrCarsonBeckett commented 3 years ago

Tested it, its still the same. From what I read in the patch / note in the commit, its no wonder since the message(-content) itself is displayed wrong and not only the subject. Or did I misunderstood that?

DrCarsonBeckett commented 3 years ago

The odd thing is, that only the backup report mail seems to be wrong. All other emails are encoded correctly (everywhere). Even usermin got issues displaying it correctly, so its not only related to Outlook.

jcameron commented 3 years ago

I looked into this, and it turns out that the code for sending backup status emails in Virtualmin is different and needed to be fixed separately.

DrCarsonBeckett commented 3 years ago

From what I talked with @iliarostovtsev (thanks again for the great support), he said the same. If I understood correctly, you guys added encoding to it. And he said, it should be fixed with the latest virtualmin package (6.14). So far, from the tests we did, it looks good ... at least for me. The last status mail I recieved was also "bug" free on all apps and devices. 😃