search

webmin / webmin

Powerful and flexible web-based server management control panel
http://www.webmin.com/
BSD 3-Clause "New" or "Revised" License
4.4k stars 646 forks source link

Usermin Configuration->Usermin Module Configuration->SpamAssassin Mail Filter #213

Closed iliajie closed 9 years ago

iliajie commented 9 years ago

For some reason, which can be deductively found out, Usermin Configuration->Usermin Module Configuration->SpamAssassin Mail Filter is not letting switch tabs in Authentic Theme, while other links' tabs from Usermin Configuration->Usermin Module Configuration are fine and are opening! Not sure what it is. May by it's hardcoded in this particular one? Please take a closer look..

Epic, Authentic Theme v13, is about to be born...

iliajie commented 9 years ago

For instance, Usermin Configuration->Usermin Module Configuration->SSH Login - works fine..

jcameron commented 9 years ago

By "switch tabs", do you mean navigating between different sections of the configuration page?

iliajie commented 9 years ago

No, I mean, when you goto Usermin Configuration->Usermin Module Configuration->SpamAssassin Mail Filter and try to switch tabs, nothing happens.

jcameron commented 9 years ago

Hmmm ... that is odd. And it works fine in the default theme, and I don't see any errors in the browser.

As the theme author, you'd probably be better at debugging this, as I assume you completely overrode the function that generates tabs?

iliajie commented 9 years ago

But it also doesn't work in Virtualmin Framed Theme, right!?

jcameron commented 9 years ago

It works OK for me in the framed theme.

iliajie commented 9 years ago

...now it really works in default themes.. :) Hmm... Sorry then, Jamie! I will take a closer look!

Could you please double check that SpamAssassin Mail Filter really is using theme_ui_tabs_ and it's not hardcoded when tabs are generated? SpamAssassin is the only one where tabs don't work..

jcameron commented 9 years ago

Yes, the same code generates that page for all usermin modules.

iliajie commented 9 years ago

Very strange.. I will do extensive debugging! Sorry.

iliajie commented 9 years ago

It was happening because the page had an element with the same id as tab-content itself. Thanks to this bug, I managed to make all tabs fail-safe.. fixed..