Added ability to specify a function name for the callback

webmodules / jsonp

A simple JSONP implementation

1.91k stars 332 forks source link

Closed rapind closed 9 years ago

rapind commented 9 years ago

Personally need it to leverage jsonp caching, but should also solve #14

roderickhsiao commented 9 years ago

any update for this PR ? @TooTallNate

TooTallNate commented 9 years ago

Seems mostly fine to me. The option name cbName I don't love so much.

/cc @rauchg thoughts?

rauchg commented 9 years ago

How about name ?

rapind commented 9 years ago

No preference here. Happy with w/e.

roderickhsiao commented 9 years ago

as we are using opts.prefix for callback prefix (not cbPrefix), guess its good to just use name

How do you guys think?

roderickhsiao commented 9 years ago

@TooTallNate @rauchg do you think the PR looks good?

seems build fails because saucelabs issue Zuul tried to run tests in saucelabs, however no saucelabs credentials were provided.

feross commented 9 years ago

PR still needs work. See inline comments.

roderickhsiao commented 9 years ago

@feross @rapind Thanks!

roderickhsiao commented 9 years ago

@TooTallNate @rauchg does the PR looks good for you guys :)

feross commented 9 years ago

LGTM

roderickhsiao commented 9 years ago

@TooTallNate @rauchg mind to take a look :+1: ? thanks

feross commented 9 years ago

@TooTallNate, @rauchg - if you add me as contributor/owner, I can take care of this release.

rauchg commented 9 years ago

0.2.0 out! Thanks. Also pinned the debug dep

roderickhsiao commented 9 years ago

Thanks all!

rapind commented 9 years ago

@roderickhsiao you're like an Open Source project management god. Keep up the good work man!

rauchg commented 9 years ago

🙏