search

webmozart / console

A usable, beautiful and easily testable console toolkit written in PHP.
MIT License
214 stars 58 forks source link

Complete the Symfony adapters for interactive and decorated #20

Closed sstok closed 8 years ago

sstok commented 8 years ago
Q A
Bug Fix? yes
New Feature? no
BC Breaks? no
Deprecations? no
Tests Pass? yes
Fixed Tickets
License MIT

This completes the adapters for the Symfony Console component. Both interactive and decorated now work as expected.

@webmozart please review this as soon as possible as the Symfony QuestionHelper doesn't work properly without these changes.

sstok commented 8 years ago

@webmozart ping, StyleCI failure is unrelated.

sstok commented 8 years ago

@webmozart ping

sstok commented 8 years ago

@webmozart ping

webmozart commented 8 years ago

Hi @sstok, sorry for the late reply! This looks good to me.