search

webmozart / path-util

A robust cross-platform utility for normalizing, comparing and modifying file paths.
MIT License
473 stars 25 forks source link

PHP 7.3 compatibility issues - "Since PHP 7.0, functions inspecting arguments, like func_get_args(), no longer report the original value as passed to a parameter, but will instead provide the current value." #32

Open praveenkaransingh opened 4 years ago

praveenkaransingh commented 4 years ago

Steps to reproduce phpcs -p -s -v --standard=PHPCompatibility vendor/webmozart/ --runtime-set testVersion 7.3 --report-full=PHP_7_3_Compatibility_vendor_webmozart.log --extensions=php,module,inc -d memory_limit=512M

Generated report from phpcs & found one warning below -

FILE: /vendor/webmozart/path-util/src/Path.php

 852 | WARNING | Since PHP 7.0, functions inspecting arguments, like func_get_args(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter "$paths" was used, and possibly
     |         | changed (by reference), on line 851. (PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValue.NeedsInspection)
praveenkaransingh commented 4 years ago

Hi @webmozart , Fix Webmozart#32 : PHP 7.3 compatibility issues fixes