webmozarts / glob

A PHP implementation of Ant's glob.
MIT License
254 stars 16 forks source link

Add PHP 8 as additional requirement #21

Closed LIQRGV closed 3 years ago

LIQRGV commented 3 years ago

Some library that use this package can't get their CI passed since this package restrict them to use PHP 8. Some example is here https://github.com/domnikl/statsd-php/pull/77

LIQRGV commented 3 years ago

I saw other PR similar with this on #19. But mine has some other changes with appveyor / travis. Can you take a look on this @webmozart, thank you...

chriskapp commented 3 years ago

vimeo/psalm uses also this dependency, so it would be great if we can merge this PR and tag a new release.

  Problem 1
    - vimeo/psalm[3.14.0, ..., 3.18.2] require webmozart/glob ^4.1 -> satisfiable by webmozart/glob[4.1.0].
    - webmozart/glob 4.1.0 requires php ^5.3.3|^7.0 -> your php version (8.0.0) does not satisfy that requirement.
LIQRGV commented 3 years ago

]

vimeo/psalm uses also this dependency, so it would be great if we can merge this PR and tag a new release.

  Problem 1
    - vimeo/psalm[3.14.0, ..., 3.18.2] require webmozart/glob ^4.1 -> satisfiable by webmozart/glob[4.1.0].
    - webmozart/glob 4.1.0 requires php ^5.3.3|^7.0 -> your php version (8.0.0) does not satisfy that requirement.

Actually, I'm updating this package because I'm using vimeo/psalm too @chriskapp lol

Nek- commented 3 years ago

The last commit on this project is in 2016.

@webmozart seems not to be maintaining any open source project for a while... Maybe this project will never be updated?!

LIQRGV commented 3 years ago

I was thinking to move it to my public repo @Nek-. Do you think it's good idea ?

Nek- commented 3 years ago

@LIQRGV shouldn't this move to friendsofphp instead?

Nek- commented 3 years ago

cc @lyrixx (context: https://github.com/webmozart/glob/issues/23 )

LIQRGV commented 3 years ago

@LIQRGV shouldn't this move to friendsofphp instead?

I'm ok anywhere as long as there is someone who maintain it

duxthefux commented 3 years ago

@LIQRGV what's the status here? as help needed somewhere?

LIQRGV commented 3 years ago

Hi @duxthefux and @Nek-, what should I do to add this to friendsofphp repo?

Nek- commented 3 years ago

I think we should wait for @webmozart because he used to give rights to projects. Maybe somebody can reach him (I know he's busy right now with important real-life stuff but we really need it) so he gives you access to this repository.

martinssipenko commented 3 years ago

I reached out to him via email and got this response:

I would be glad if someone took over the lead of the package. I've seen the PRs, but I'm lacking the time to work on them. Would you like to take over?

So the question is, where could this project be moved to? Are FriendsOfPHP willing to take over (cc @lyrixx), perhaps Psalm (cc @muglug) wants to take over as they are the largest project that uses this

Nek- commented 3 years ago

@martinssipenko I think keeping the project here is fine. We just need to elect a maintainer. @LIQRGV seems to be a good candidate WDYT? ^^

(if nobody wants to do it I can do it)

LIQRGV commented 3 years ago

I'm ok with anything as long as this project updated. 😁

MidnightDesign commented 3 years ago

No offense to @LIQRGV, but @Nek- seems a little more experienced with open source. Maybe both, so we don't end up in the same situation again someday. : )

martinssipenko commented 3 years ago

I imagine @Ocramius has a ton of stuff on his plate but perhaps he wants to take over? He does have the most experience with OS.

Nek- commented 3 years ago

@martinssipenko if you can ask for @LIQRGV and me to have access to the repository it would be fine. We'll try to ensure it works properly in the future. (we need to end this fast instead of useless debate ;) )

Ocramius commented 3 years ago

@martinssipenko I don't mind helping, but the biggest problem is usually getting someone to fiddle with the repo configuration, which doesn't work for contributors.

I'd push some release automation tool ASAP, so that we can ease merges, but need access to repo secrets to do so.

Push rights are the smaller part of the task here 😅

martinssipenko commented 3 years ago

@martinssipenko I don't mind helping, but the biggest problem is usually getting someone to fiddle with the repo configuration, which doesn't work for contributors.

I'd push some release automation tool ASAP, so that we can ease merges, but need access to repo secrets to do so.

Push rights are the smaller part of the task here 😅

So perhaps transferring/cloning to another account is better approach?

Ocramius commented 3 years ago

So perhaps transferring/cloning to another account is better approach?

Absolutely: it allows multiple owners, which is kinda needed for redundancy.

martinssipenko commented 3 years ago

Frankly, I don't know what to do next, reach out to friendsofphp?

LIQRGV commented 3 years ago

Transferring to another repo would lead to updating any repo that use this into new repo. Just saying

localheinz commented 3 years ago

@LIQRGV

Transferring to another repo would lead to updating any repo that use this into new repo.

Not necessary:

martinssipenko commented 3 years ago

That is true, but not transferring means things don't change as the original maintainer has no time to fiddle with repo config. If transferred this could marked as abandoned and suggest using a fork.

@Ocramius you wanna fork?

duxthefux commented 3 years ago

If we're forking, this would basically mean this repo needs be archived and a replacement suggestions needs to be placed in README and composer.json to make a good dev experience.

Nek- commented 3 years ago

If an organization should fork this repo, it should be psalm. This is the project that needs it the most. (5 573 473 downloads for this one and 4 871 588 for psaml)

martinssipenko commented 3 years ago

@Nek- I took a closer look, Psalm stopped using this since version 4.1.0.

webmozart commented 3 years ago

Hi all! Sorry for being so unresponsive. I'll do my best to help you fix this quickly. Let me consider a few options and then get back to you with proposals.

martinssipenko commented 3 years ago

This repo has now been moved to webmozarts org and @Ocramius and @Nek- have been made as repository maintainers.

Ocramius commented 3 years ago

Ported @LIQRGV's commits to #24 - waiting for some administrative mumbo-jumbo to happen before I can start rolling out releases :-)