search

webmozarts / glob

A PHP implementation of Ant's glob.
MIT License
254 stars 16 forks source link

Support PHP 8.1.0 #56

Closed asika32764 closed 3 years ago

asika32764 commented 3 years ago

Add #[\ReturnTypeWillChange] to avoid type error.

Ocramius commented 3 years ago

Need 8.1 in the pipeline to validate this fix

Ocramius commented 3 years ago

Hmm, seems like this will wait for upstream support for 8.1 in builds (probably happening in September, after RC builds are available - ping me then :) )

Ocramius commented 3 years ago

LGTM :+1:

We can upgrade to 8.0 post-release, if the pipeline decides to fail for whatever reason :-)