Closed DanielBadura closed 2 years ago
Wouldn't it make more sense to feed that back to Symfony instead? Excluding Symfony dependencies on principle sounds exuberant to me (I'm trying hard not to say "crazy").
TBH, since symfony has gone completely wrong from a dependency PoV (see https://github.com/symfony/symfony/pull/36876), and to not introduce a circular dependency for a tiny use-case scenario, it's best to break the dependency graph here, and avoid the dependency overall.
The only use-cases are:
https://github.com/webmozarts/glob/blob/088aea5388f0325c2da9a9bb30de9546049e4ca4/src/Glob.php#L316-L321 https://github.com/webmozarts/glob/blob/088aea5388f0325c2da9a9bb30de9546049e4ca4/src/Glob.php#L461-L466
A dependency for that is avoidable.
In fact, dragging in pre-existing code and tests from webmozarts/path-util
is preferable:
Thanks, I missed that "discussion" :wink: That comment explains it pretty well though and it makes sense to me:
Please note that Symfony's promise is to have support for all new PHP versions in all versions that aren't yet end-of-life. This means that if 3.4.40 doesn't support PHP 8, 3.4.41 will.
Anyways, since the touchpoint is so small, I understand that it makes sense not to introduce the library at all.
Please note that Symfony's promise is to have support for all new PHP versions in all versions that aren't yet end-of-life. This means that if 3.4.40 doesn't support PHP 8, 3.4.41 will.
FWIW, I'm 4h in in trying to fix some issues with the lax dependency requirements of symfony (on a separate private project): my trust in anything symfony/*
has grown extremely thin.
Removed dependency in #60
Just porting the issue from https://github.com/maglnet/ComposerRequireChecker/issues/315 and quoting @Ocramius:
I dont know another non-symfony package that is doing the stuff needed. Only used path-util / glob or filesystem / finder, so suggestions welcome i guess 👯